Categorized tenants

[hishamco]

Addresses #10402

• Sorting
• Filtering
• Pagination
• Searching

[hishamco]

I just added a Category to each tenant in tenants.json for simplicity and avoid any sort of breaking-changes

[agriffard]

I don't see how we can have at the same time categories and pagination.

Ex: try.orchardcore.net currently has hundreds of tenants.

[hishamco]

I don't see how we can have at the same time categories and pagination.

I add it to my TODO list, BWT the categories should not affect the sorting, filtering & pagination, the actual tenant should

[hishamco]

@agriffard there's a little weired behavior during pagination, some categories are divided across the pages, I presume this is because the current ordering. It would be nice to check this PR against try.orchardcore.net or send me a user credentials PM if it's possible

Thanks

[deanmarcussen]

Yeah I’m with @agriffard this will not work like this.

it’s also completely unlike any ui we have.

Suggest you look at the other search ui and make categories a filter in the controller. Workflows is as good example as any.

the button to go beside the sort button and list the categories

[hishamco]

Suggest you look at the other search ui and make categories a filter in the controller.

This is a good option, which may simplify listing the projects, I suggest to display the category a longside the name and add it as a filter. If this sounds looks good I will change the PR now

[hishamco]

I will do it like the category types in content items page

[hishamco]

[deanmarcussen]

I don't like Not Categorized. For any existing user it would force them to go through and categorise all their tenants, just to get rid of an odd bit of text.

Categories (if we do it), should be optional.
So just use String.Empty, and None in the filter list (like we do elsewhere), and don't show anything if it is String.Empty`

And equally don't show the filter if there are no categories.

[hishamco]

And equally don't show the filter if there are no categories.

So, how can we list the tenants that they don't have category?

And equally don't show the filter if there are no categories.

+1

[deanmarcussen]

So, how can we list the tenants that they don't have category?

you would have an All. It would be the default.

We would never have a filter that forces people to put things into categories.

[hishamco]

you would have an All. It would be the default.

No make sense, coz when you said None before ;) I will update the PR soon ...

[hishamco]

Any updates on this?

[sebastienros]

Can you update the screenshots if you removed the "not categorized" ?

[hishamco]

[hishamco]

Please don't merge after I double check the merge conflict

[deanmarcussen]

@hishamco you have missed my previous review.

Where I said that None shouldn't be showing.

If people aren't wanting to categorise their tenants (I can't think of any category I'd give mine, they are all of the same type), then having a ranom None tag showing up makes no sense.

i.e. Ok, with categorising, not ok with forcing it on users.

[hishamco]

Oops, seems I forgot this one, I will update the PR soon ...

[hishamco]

If there's no other comment, then the PR is ready to merge

[hishamco]

[hishamco]

@deanmarcussen anything left here or can we approve then merge?

[deanmarcussen]

Two minor issues to fix. Otherwise looks good

[deanmarcussen]

You forgot to remove the default category - it's unnecesary

[hishamco]

Seems I forgot to push a local commit from awhile ;)