Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localizer type in tenants ApiController #10987

Merged
merged 1 commit into from
Jan 8, 2022
Merged

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Jan 8, 2022

No description provided.

@hishamco
Copy link
Member Author

hishamco commented Jan 8, 2022

@Piedone I remember that you mentioned long time before that we need sort of analyzer, indeed this one of the common cases that we need such analyzer, if it will take long time here we can add it to Lombiq Analyzer

@hishamco hishamco merged commit 6738202 into main Jan 8, 2022
@hishamco hishamco deleted the hishamco/fix-localizer branch January 8, 2022 08:10
@Piedone
Copy link
Member

Piedone commented Jan 8, 2022

Thank you, made a note of this here: Lombiq/.NET-Analyzers#15 There's no such analyzer currently, unfortunately.

@hishamco
Copy link
Member Author

hishamco commented Jan 8, 2022

I can contribute to this one

@hishamco hishamco added this to the 1.3 milestone Jan 8, 2022
@Piedone
Copy link
Member

Piedone commented Jan 9, 2022

Really? That would be awesome, actually!

@hishamco
Copy link
Member Author

hishamco commented Jan 9, 2022

I will add your link in my list of this month, hope to have a look soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants