Enable Graphql queries to support total when using Lucene queries #11159

hyzx86 · 2022-02-11T06:22:11Z

Change the query schema to the following: add 'hasTotal' :true

{
  "type":"contentItem/TableProducts",
 "hasTotal":true
}

#6939

hyzx86 · 2022-02-11T06:29:18Z

Regarding the "hasTotal":true option, I want it to be the default
I notice this PR is in the works, maybe it can be released with this feature?
#11052

aminmohammadi05 · 2022-09-20T12:10:37Z

What if when there are multiple content types?

[{
  "type":"contentItem/TableProducts",
 "hasTotal":true
},
{
  "type":"contentItem/Type2",
 "hasTotal":true
}]

hyzx86 · 2022-09-20T12:29:20Z

@aminmohammadi05 have you try graphql ?

hishamco

This is a quick review, please check the format in all the places

src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs

hishamco · 2022-09-20T12:59:39Z

src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs

@@ -149,7 +164,7 @@ private FieldType BuildSchemaBasedFieldType(LuceneQuery query, JToken querySchem
                        JsonConvert.DeserializeObject<Dictionary<string, object>>(parameters)
                        : new Dictionary<string, object>();

-                    var result = await queryManager.ExecuteQueryAsync(iquery, queryParameters);
+                    var result = (await queryManager.ExecuteQueryAsync(iquery, queryParameters)) as OrchardCore.Lucene.LuceneQueryResults;


you can do the LuceneQueryResults casting in the return

hishamco · 2022-09-20T13:00:18Z

src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs

@@ -185,14 +199,163 @@ private FieldType BuildContentTypeFieldType(ISchema schema, string contentType,
                    var queryParameters = parameters != null ?
                        JsonConvert.DeserializeObject<Dictionary<string, object>>(parameters)
                        : new Dictionary<string, object>();
-
-                    var result = await queryManager.ExecuteQueryAsync(iquery, queryParameters);
+                    var result = (await queryManager.ExecuteQueryAsync(iquery, queryParameters)) as OrchardCore.Lucene.LuceneQueryResults;


Same as above

src/OrchardCore.Modules/OrchardCore.Lucene/GraphQL/LuceneQueryFieldTypeProvider.cs

aminmohammadi05 · 2022-09-21T03:50:31Z

@aminmohammadi05 have you try graphql ?
Yes but it does not shown in the graphql

hyzx86 · 2022-09-21T03:53:30Z

@aminmohammadi05 have you try graphql ?
Yes but it does not shown in the graphql

cuz , you haven't input the schema field

aminmohammadi05 · 2022-09-21T04:53:07Z

@aminmohammadi05 have you try graphql ?
Yes but it does not shown in the graphql

cuz , you haven't input the schema field

How to do that?

hyzx86 · 2022-09-21T04:54:54Z

@aminmohammadi05 have you try graphql ?
Yes but it does not shown in the graphql

cuz , you haven't input the schema field

How to do that?

aminmohammadi05 · 2022-09-21T05:01:10Z

@aminmohammadi05 have you try graphql ?
Yes but it does not shown in the graphql

cuz , you haven't input the schema field

How to do that?

I mean when I put type Product in type field it shows just Product type field in Graphiql but I need it to show Blog type field also

hyzx86 · 2022-09-21T05:02:39Z

aminmohammadi05 · 2022-09-21T05:05:35Z

This is a Lucene search query which I need to provide parameters for it to search the parameters in all the selected types: Product, Blog

hyzx86 · 2022-09-21T05:08:01Z

aminmohammadi05 · 2022-09-21T05:12:04Z

I know, I want to set the schema field of the Lucene query in a way that the "searchAll" query shows fields of the both Product and Blog types

hyzx86 · 2022-09-21T05:15:08Z

#11052

I noticed that this function was merged into the main branch yesterday

hyzx86 · 2022-09-21T05:17:50Z

I know, I want to set the schema field of the Lucene query in a way that the "searchAll" query shows fields of the both Product and Blog types

Lucene query should not do what you said. It stores some types in a table containing many fields
If you want to query two types at the same time, you may need to perform secondary filtering on the client

aminmohammadi05 · 2022-09-21T05:33:30Z

I know, I want to set the schema field of the Lucene query in a way that the "searchAll" query shows fields of the both Product and Blog types

Lucene query should not do what you said. It stores some types in a table containing many fields If you want to query two types at the same time, you may need to perform secondary filtering on the client

No problem, how can I query two types at the same time. As you said I can handle separating the result based on its type.

hyzx86 · 2022-09-21T05:35:53Z

No problem, how can I query two types at the same time. As you said I can handle separating the result based on its type.

have you try object type?

https://docs.orchardcore.net/en/latest/docs/reference/modules/Queries/#graphql

aminmohammadi05 · 2022-09-21T05:40:17Z

No problem, how can I query two types at the same time. As you said I can handle separating the result based on its type.

have you try object type?

https://docs.orchardcore.net/en/latest/docs/reference/modules/Queries/#graphql

Yeah I saw that, I wonder how to query two types at the same time. As you see the document only shows one type: "BlogPost". Can you provide an example?

hyzx86 · 2022-09-26T09:49:10Z

Not ready , I'm trying to implement more flexible schema configuration, such as

{
items: {"type":"Array","ofType":"Blog"},
total: {"type":"Integer"},
}

aminmohammadi05 · 2022-10-22T10:51:26Z

Change the query schema to the following: add 'hasTotal' :true
{
  "type":"contentItem/TableProducts",
 "hasTotal":true
}
#6939

I tried this one to return total records but it did not work. What else should I do to get the result?

aminmohammadi05 · 2022-10-23T06:42:07Z

this is the schema

aminmohammadi05 · 2022-10-23T06:45:24Z

And the GraphQl output

hyzx86 · 2022-10-23T06:48:00Z

Looks like the code is not work ,Do you use my branch directly?

aminmohammadi05 · 2022-10-23T06:54:08Z

No I downloaded it via Nuget package manager in Visual Studio 2022 3 months ago

hyzx86 · 2022-10-23T06:56:03Z

No I downloaded it via Nuget package manager in Visual Studio 2022 3 months ago

This feature only work on my branch...

aminmohammadi05 · 2022-10-23T06:58:09Z

So how can I get total records without using you branch? cuz I am in the middle of development and feel it risky to change the Orchard

hyzx86 · 2022-10-23T07:06:23Z

So how can I get total records without using you branch? cuz I am in the middle of development and feel it risky to change the Orchard

You can directly use the WebAPI : api/queries/{name}

https://docs.orchardcore.net/en/latest/docs/reference/modules/Queries/#breaking-changes

aminmohammadi05 · 2022-10-23T07:12:26Z

Thanks a lot.

hyzx86 · 2023-03-29T06:52:36Z

@hishamco

I thought, is it possible to change the UI of LuceneQuery to add a checkbox, which can togdle the total field

What do you think?

github-actions · 2024-02-08T18:54:27Z

This pull request has merge conflicts. Please resolve those before requesting a review.

Piedone · 2024-03-13T17:38:12Z

I think this would be useful, but only if you implement parity with the Elasticsearch queries too. @Skrypt could you please chime in here?

sebastienros · 2024-03-14T17:53:09Z

Why not always have a count property and if the provider supports it return the value or -1 if it's not available. 0 would mean no items when the query supports it.

hyzx86 · 2024-03-14T17:59:20Z

Of course that would be best, but that would introduce a disruptive change.
Because the current query api returns a collection type

hyzx86 · 2024-03-14T18:03:39Z

In addition, we have discussed quantity statistics implemented on SQL Query
#6939

github-actions · 2024-06-27T02:00:41Z

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

github-actions · 2024-07-12T04:39:59Z

Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it.

Enable Graphql queries to support total when using Lucene queries

05d8fc9

hyzx86 requested a review from Skrypt as a code owner February 11, 2022 06:22

hyzx86 mentioned this pull request May 22, 2022

Does the query now support returning the total number of rows? #6939

Closed

Skrypt added the needs triage label May 22, 2022

hishamco requested changes Sep 20, 2022

View reviewed changes

hyzx86 closed this Sep 26, 2022

hyzx86 reopened this Sep 26, 2022

hyzx86 added 4 commits October 22, 2022 20:56

Update LuceneQueryFieldTypeProvider.cs

0a72cd4

Merge main

921dbb9

Simplify hasTotal check logic

8698a41

merge conflict

36f2cbc

hyzx86 added 2 commits March 29, 2023 15:03

Add HasTotal Option on LuceneQuery

7ac8c6a

Merge branch 'origin_main' into lucene_total

72a99ff

hyzx86 requested review from hishamco and removed request for Skrypt March 29, 2023 07:05

fix Update Query

22f0600

Skrypt added the GraphQL label Mar 30, 2023

github-actions bot added the merge conflict label Feb 8, 2024

Skrypt requested review from Skrypt and removed request for hishamco March 13, 2024 17:58

Piedone removed the needs triage label Apr 25, 2024

github-actions bot added the stale label Jun 27, 2024

github-actions bot closed this Jul 12, 2024

This was referenced Aug 18, 2024

Release v2.0.0 #16428

Closed

Adding document counts to the query API #16578

Open

Enable Graphql queries to support total when using Lucene queries #11159

Enable Graphql queries to support total when using Lucene queries #11159

Conversation

hyzx86 commented Feb 11, 2022 • edited Loading

hyzx86 commented Feb 11, 2022

aminmohammadi05 commented Sep 20, 2022

hyzx86 commented Sep 20, 2022

hishamco left a comment

Choose a reason for hiding this comment

hishamco Sep 20, 2022

Choose a reason for hiding this comment

hishamco Sep 20, 2022

Choose a reason for hiding this comment

aminmohammadi05 commented Sep 21, 2022

hyzx86 commented Sep 21, 2022

aminmohammadi05 commented Sep 21, 2022

hyzx86 commented Sep 21, 2022

aminmohammadi05 commented Sep 21, 2022 • edited Loading

hyzx86 commented Sep 21, 2022

aminmohammadi05 commented Sep 21, 2022

hyzx86 commented Sep 21, 2022

aminmohammadi05 commented Sep 21, 2022

hyzx86 commented Sep 21, 2022

hyzx86 commented Sep 21, 2022

aminmohammadi05 commented Sep 21, 2022 • edited Loading

hyzx86 commented Sep 21, 2022

aminmohammadi05 commented Sep 21, 2022 • edited Loading

hyzx86 commented Sep 26, 2022 • edited Loading

aminmohammadi05 commented Oct 22, 2022

aminmohammadi05 commented Oct 23, 2022

aminmohammadi05 commented Oct 23, 2022

hyzx86 commented Oct 23, 2022

aminmohammadi05 commented Oct 23, 2022

hyzx86 commented Oct 23, 2022

aminmohammadi05 commented Oct 23, 2022

hyzx86 commented Oct 23, 2022

aminmohammadi05 commented Oct 23, 2022

hyzx86 commented Mar 29, 2023 • edited Loading

github-actions bot commented Feb 8, 2024

Piedone commented Mar 13, 2024

sebastienros commented Mar 14, 2024

hyzx86 commented Mar 14, 2024

hyzx86 commented Mar 14, 2024 • edited Loading

github-actions bot commented Jun 27, 2024

github-actions bot commented Jul 12, 2024

hyzx86 commented Feb 11, 2022 •

edited

Loading

aminmohammadi05 commented Sep 21, 2022 •

edited

Loading

aminmohammadi05 commented Sep 21, 2022 •

edited

Loading

aminmohammadi05 commented Sep 21, 2022 •

edited

Loading

hyzx86 commented Sep 26, 2022 •

edited

Loading

hyzx86 commented Mar 29, 2023 •

edited

Loading

hyzx86 commented Mar 14, 2024 •

edited

Loading