Fix invalid cookie name caused by parenthesis in path name #11489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
reviewed
Apr 4, 2022
| @@ -312,7 +312,7 @@ private static void AddAntiForgery(OrchardCoreBuilder builder) | |||
| var settings = serviceProvider.GetRequiredService<ShellSettings>(); | |||
| var environment = serviceProvider.GetRequiredService<IHostEnvironment>(); | |||
|
|
|||
| var cookieName = "orchantiforgery_" + HttpUtility.UrlEncode(settings.Name + environment.ContentRootPath); | |||
| var cookieName = "orchantiforgery_" + HttpUtility.UrlEncode(settings.Name + environment.ContentRootPath.Replace("(", "").Replace(")", "")); | |||
There was a problem hiding this comment.
Can we define a static array of the invalid characters, then we can remove them from ContentRootPath
There was a problem hiding this comment.
Let's use the slugify method here. It will do "that".
There was a problem hiding this comment.
Hmm, ISlugService and SlugService should be moved somewhere else than the OrchardCore.Liquid module.
There was a problem hiding this comment.
Sure. This approach is way better and scapes all the characters
| @@ -312,7 +312,7 @@ private static void AddAntiForgery(OrchardCoreBuilder builder) | |||
| var settings = serviceProvider.GetRequiredService<ShellSettings>(); | |||
| var environment = serviceProvider.GetRequiredService<IHostEnvironment>(); | |||
|
|
|||
| var cookieName = "orchantiforgery_" + HttpUtility.UrlEncode(settings.Name + environment.ContentRootPath); | |||
| var cookieName = "orchantiforgery_" + HttpUtility.UrlEncode(settings.Name + environment.ContentRootPath.Replace("(", "").Replace(")", "")); | |||
There was a problem hiding this comment.
I think the issue is with the encoding logic, UrlEncode is apparently not adapted. Base64 or Uri.EscapeDataString (something close).
Also we can use a Guid.ToString("N") instead of the ContentRootPath.
Details: #5803
sebastienros
added a commit
that referenced
this pull request
Jun 9, 2022
Skrypt
added a commit
that referenced
this pull request
Sep 22, 2022
# Conflicts: # OrchardCore.sln # src/OrchardCore/OrchardCore.Queries.Abstractions/LuceneQueryResults.cs
Skrypt
added a commit
that referenced
this pull request
Oct 8, 2022
Skrypt
added a commit
that referenced
this pull request
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi when the root path is a in a Windows directory that contains parenthesis I get the following antiforgery error
I believe his happens since the project upgraded to a .NET Core version that no longer scapes characters in the antiforgery cookie (3 or 5 I don't remember the version). I encounter this error while deploying release version on Windows Server or while developing with Visual Studio when the project is inside a folder with parenthesis.
Repro steps:
This pr fixes this error. I don't know if it could be more problematic characters since HttpUtility.UrlEncode method can get rid of them.