Fix content item display coordinator when a GroupId is provided #11714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulling new updates
|
Hard to understand the changes since there are indentations changes that mess-up with the diff. |
@sebastienros the main different is adding shapeResult.OnGroup(context.GroupId) and typePartShapeResult.OnGroup(groupId); without honoring the GroupId from current context, the Other stuff is just code cleanup to reduce it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ContentItemDisplayCoordinatorhas an issue where it was not rendering the parts on Edit when a groupId is provided. Explained in #11718This PR calls
shapeResult.OnGroup(context.GroupId);to ensure the shape is rendered with a groupId is provided fixed #11718Also, slightly cleans up the code.