Allow Default tenant’s admin to assign multiple feature-profiles to the same tenant #11841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
changed the title
|
@sebastienros this has been setting for a while. Can you please take a look? |
src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
sebastienros
approved these changes
Dec 29, 2022
src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Tenants/Services/FeatureProfilesManager.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Tenants/ViewModels/TenantViewModel.cs
Outdated
Show resolved
Hide resolved
jtkech
reviewed
Jan 3, 2023
src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
|
Oops sorry didn't have time to review this one again, but first need to complete #13040 as it is related to a breaking change, but there are many scenarios so it may take some times, I will try this week end. |
|
@jtkech do you have any further update here? |
|
Okay, will look at it next night |
MikeAlhayek
commented
Jan 25, 2023
src/OrchardCore.Modules/OrchardCore.Tenants/TenantsConstants.cs
Outdated
Show resolved
Hide resolved
jtkech
reviewed
Jan 25, 2023
src/OrchardCore/OrchardCore/Shell/FeatureProfilesValidationProvider.cs
Outdated
Show resolved
Hide resolved
|
@jtkech fixed conflicts we had. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provide few enhancements to the Tenants modules discussed in #10963
Fix #10963
Here are some of the highlights.
FeatureProfileadd anidto the profile instead of using the existing editable name. This way renaming profile won't break anything. To keep it backward compatible, we treat current name as the id for old entries. Note renaming old entries won't cause any issue since we consider the id as the name before the new name is saved.This PR to replace #10996