Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize ContentTypeExtensions #12231

Merged
merged 11 commits into from
Sep 16, 2022
Merged

Utilize ContentTypeExtensions #12231

merged 11 commits into from
Sep 16, 2022

Conversation

MikeAlhayek
Copy link
Member

Clean up some of the code by using the new ContentTypeExtensions extensions
Fix #12230

hishamco
hishamco requested changes Aug 20, 2022
View reviewed changes
Copy link
Member

@hishamco hishamco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost fine except few comments for clarification

MikeAlhayek and others added 2 commits August 22, 2022 08:15
@MikeAlhayek @Skrypt
Fix a typo
44219d9 
Co-authored-by: Jasmin Savard <[email protected]>
@MikeAlhayek
Fix a Typo
2d2fdf1
@sebastienros
Copy link
Member

The OrDefault seems extraneous, we don't do that for all the things that can return a null/empty string. And I don't want we start doing it for all the new properties returning strings. One day (in a few years) we'll use nullability checks for that.

@MikeAlhayek
Copy link
Member Author

@sebastienros I removed OrDefault

@Skrypt Skrypt merged commit 0506ecd into OrchardCMS:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtkech jtkech jtkech left review comments

@hishamco hishamco hishamco requested changes

@sebastienros sebastienros sebastienros approved these changes

@Skrypt Skrypt Awaiting requested review from Skrypt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up some of the code by using the new ContentTypeExtensions
5 participants
@MikeAlhayek @sebastienros @Skrypt @hishamco @jtkech