Fix SmtpService to validate email address #12253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns8482e
requested changes
Aug 24, 2022
| var mimeMessage = FromMailMessage(message); | ||
| var errors = new List<LocalizedString>(); | ||
|
|
||
| var mimeMessage = FromMailMessage(message, errors); |
There was a problem hiding this comment.
Not sure if errors should be part of FromMailMessage method? may be just create IsValid method separate from FromMailMessage method
There was a problem hiding this comment.
@ns8482e this is how the class was designed. All we did here is create more checks to ensure we report proper error instead of throwing exception
|
"Invalid {0} email." -> "Invalid email address: '{0}'" this way only one string is translated, and users can see what actual address is wrong. |
|
@sebastienros fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12252