Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear alternates before morphing Stereotypes #12260

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Aug 24, 2022

Fix #12259

The same result could be achieved by removing Widget.Edit.cshtml and DashboardWidget.Edit.cshtml from the project and let Stereotype.Edit.cshtml handle the rendering "since that is what it's made for".

I would rather delete both Widget.Edit.cshtml and DashboardWidget.Edit.cshtml templates in this case, but not sure if the team want them kept.

@MikeAlhayek MikeAlhayek marked this pull request as ready for review August 24, 2022 17:25
@sebastienros sebastienros merged commit d2626f4 into OrchardCMS:main Aug 25, 2022
@Skrypt Skrypt added this to the 1.5 milestone Aug 26, 2022
@MikeAlhayek MikeAlhayek deleted the FixWidgets branch September 2, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear alternates before morphing Stereotypes otherwise we run into infinite loop
3 participants