Lucene index rebuild and reset steps (Lombiq Technologies: OCORE-101) #12302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It just misses some documentation about the recipes. |
Piedone
changed the title
Piedone
requested changes
Aug 31, 2022
src/OrchardCore.Modules/OrchardCore.Lucene/Deployment/LuceneIndexRebuildDeploymentStep.cs
Outdated
Show resolved
Hide resolved
...e.Modules/OrchardCore.Lucene/Views/Items/LuceneIndexRebuildDeploymentStep.Fields.Edit.cshtml
Outdated
Show resolved
Hide resolved
...e.Modules/OrchardCore.Lucene/Views/Items/LuceneIndexRebuildDeploymentStep.Fields.Edit.cshtml
Outdated
Show resolved
Hide resolved
...e.Modules/OrchardCore.Lucene/Views/Items/LuceneIndexRebuildDeploymentStep.Fields.Edit.cshtml
Outdated
Show resolved
Hide resolved
...ore.Modules/OrchardCore.Lucene/Views/Items/LuceneIndexResetDeploymentStep.Fields.Edit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Lucene/Deployment/LuceneIndexRebuildDeploymentStepDriver.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexRebuildStep.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexResetStep.cs
Outdated
Show resolved
Hide resolved
25 tasks
Skrypt
reviewed
Sep 5, 2022
Skrypt
reviewed
Sep 6, 2022
src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexResetStep.cs
Outdated
Show resolved
Hide resolved
Skrypt
reviewed
Sep 6, 2022
src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexResetStep.cs
Outdated
Show resolved
Hide resolved
Skrypt
reviewed
Sep 6, 2022
src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexResetStep.cs
Outdated
Show resolved
Hide resolved
Skrypt
approved these changes
Sep 9, 2022
Piedone
requested changes
Sep 9, 2022
src/OrchardCore.Themes/TheBlogTheme/Recipes/blog.lucene.search.recipe.json
Show resolved
Hide resolved
|
Please, still don't resolve convos so I don't have to open them one by one to see how you addressed my feedback. |
Piedone
requested changes
Sep 11, 2022
src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexRebuildStep.cs
Outdated
Show resolved
Hide resolved
Piedone
requested changes
Sep 11, 2022
src/OrchardCore.Modules/OrchardCore.Lucene/Recipes/LuceneIndexRebuildStep.cs
Outdated
Show resolved
Hide resolved
lampersky
requested review from
deanmarcussen,
kevinchalet,
hishamco,
Jetski5822 and
carlwoodhouse
as code owners
lampersky
force-pushed
the
lampersky/lucene-index-rebuild-reset
branch
from
49fd3ba
to
42abd02
Compare
|
closing this PR, because I've messed up a bit, new PR is available here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12199