Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null check in ContentAnchorTag #12326

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Fix null check in ContentAnchorTag #12326

merged 1 commit into from
Sep 9, 2022

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Sep 4, 2022

This PR fixes a null check in

if (metadata.CreateRouteValues == null) // BUG
    {
      if (routeValues != null)
      {
        foreach (var attribute in routeValues)
        {
          metadata.CreateRouteValues.Add(attribute.Key, attribute.Value);     
        }
      }
      ....
    }

Also I did a little refactoring

@hishamco hishamco added this to the 1.5 milestone Sep 6, 2022
@agriffard agriffard changed the title Fix null check in CotentAnchorTag Fix null check in ContentAnchorTag Sep 9, 2022
@agriffard agriffard merged commit 3aa983e into main Sep 9, 2022
@agriffard agriffard deleted the content-anchor-tag branch September 9, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants