Add missing null check operator in ShellSettingsManager.EnsureConfigurationAsync() #12328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skrypt
approved these changes
Sep 5, 2022
jtkech
reviewed
Sep 5, 2022
| @@ -239,7 +239,7 @@ private async Task EnsureConfigurationAsync() | |||
| .AddConfiguration(_applicationConfiguration) | |||
| .AddSourcesAsync(_tenantsConfigSources); | |||
|
|
|||
| if (lastProviders.Count() > 0) | |||
| if (lastProviders?.Length > 0) | |||
There was a problem hiding this comment.
Take care of this kind of changes, here that's okay as we are using > 0.
But we could have used !=0, in which case it would have been wrong.
int? test = null;
if (test > 0) // This is evaluated to false.
{
;
}
else if (test != 0) // But this is evaluated to true.
{
;
}
That's why it's safer to use test != null && test > 0 or test.HasValue && test.Value > 0.
There was a problem hiding this comment.
I think actually this is a new code recommendation from Visual Studio to change .Count() to .Length in some places.
There was a problem hiding this comment.
Yes it is better, no problem about changing Count() to Length, I was talking about keeping the previous behavior when dealing with nullable types, here with the .? operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.