Avoid NRE in ImportRemoteInstanceController.import() #12330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skrypt
reviewed
Sep 5, 2022
...hardCore.Modules/OrchardCore.Deployment.Remote/Controllers/ImportRemoteInstanceController.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jasmin Savard <[email protected]>
Skrypt
approved these changes
Sep 5, 2022
jtkech
reviewed
Sep 6, 2022
| @@ -43,9 +43,14 @@ public async Task<IActionResult> Import(ImportViewModel model) | |||
|
|
|||
| var remoteClient = remoteClientList.RemoteClients.FirstOrDefault(x => x.ClientName == model.ClientName); | |||
|
|
|||
| if (remoteClient == null) | |||
| { | |||
| return StatusCode((int)HttpStatusCode.BadRequest, "The remote client was not provided"); | |||
There was a problem hiding this comment.
Just for info the following does the same, yes better to not do it here for consistency with other lines of code below, but maybe a good canditate for a separate PR ;)
return BadRequest("The remote client was not provided");
There was a problem hiding this comment.
I will try to check the entire code to see if we have such thing .. thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.