Replace StatusCode() when its possible

src/OrchardCore.Modules/OrchardCore.AdminDashboard/Controllers/DashboardController.cs

@@ -149,7 +149,7 @@ public async Task<IActionResult> Update([FromForm] DashboardPartViewModel[] part
         {
             if (!await _authorizationService.AuthorizeAsync(User, Permissions.ManageAdminDashboard))
             {
-                return StatusCode(401);
+                return Unauthorized();
             }
 
             var contentItemIds = parts.Select(i => i.ContentItemId).ToArray();
@@ -161,15 +161,15 @@ public async Task<IActionResult> Update([FromForm] DashboardPartViewModel[] part
 
             if (latestItems == null)
             {
-                return StatusCode(404);
+                return NotFound();
             }
 
             foreach (var contentItem in latestItems)
             {
                 var dashboardPart = contentItem.As<DashboardPart>();
                 if (dashboardPart == null)
                 {
-                    return StatusCode(403);
+                    return Forbid();
                 }
 
                 var partViewModel = parts.Where(m => m.ContentItemId == contentItem.ContentItemId).FirstOrDefault();
@@ -200,7 +200,7 @@ public async Task<IActionResult> Update([FromForm] DashboardPartViewModel[] part
 
             if (Request.Headers != null && Request.Headers["X-Requested-With"] == "XMLHttpRequest")
             {
-                return StatusCode(200);
+                return Ok();
             }
             else
             {

src/OrchardCore.Modules/OrchardCore.AdminMenu/Controllers/NodeController.cs

@@ -265,7 +265,7 @@ public async Task<IActionResult> Delete(string id, string treeNodeId)
 
             if (adminMenu.RemoveMenuItem(treeNode) == false)
             {
-                return new StatusCodeResult(500);
+                return this.InternalServerError();
             }
 
             await _adminMenuService.SaveAsync(adminMenu);

src/OrchardCore.Modules/OrchardCore.ContentPreview/Controllers/PreviewController.cs

@@ -92,7 +92,7 @@ public async Task<IActionResult> Render()
                     }
                 }
 
-                return StatusCode(500, new { errors = errors });
+                return this.InternalServerError(new { errors });
             }
 
             var previewAspect = await _contentManager.PopulateAspectAsync(contentItem, new PreviewAspect());

src/OrchardCore.Modules/OrchardCore.Contents/Controllers/ApiController.cs

@@ -71,7 +71,7 @@ public async Task<IActionResult> Delete(string contentItemId)
 
             if (contentItem == null)
             {
-                return StatusCode(204);
+                return NoContent();
             }
 
             if (!await _authorizationService.AuthorizeAsync(User, CommonPermissions.DeleteContent, contentItem))

src/OrchardCore.Modules/OrchardCore.Layers/Controllers/AdminController.cs

@@ -288,22 +288,22 @@ public async Task<IActionResult> UpdatePosition(string contentItemId, double pos
         {
             if (!await _authorizationService.AuthorizeAsync(User, Permissions.ManageLayers))
             {
-                return StatusCode(401);
+                return Unauthorized();
             }
 
             // Load the latest version first if any
             var contentItem = await _contentManager.GetAsync(contentItemId, VersionOptions.Latest);
 
             if (contentItem == null)
             {
-                return StatusCode(404);
+                return NotFound();
             }
 
             var layerMetadata = contentItem.As<LayerMetadata>();
 
             if (layerMetadata == null)
             {
-                return StatusCode(403);
+                return Forbid();
             }
 
             layerMetadata.Position = position;
@@ -324,7 +324,7 @@ public async Task<IActionResult> UpdatePosition(string contentItemId, double pos
 
                     if (layerMetadata == null)
                     {
-                        return StatusCode(403);
+                        return Forbid();
                     }
 
                     layerMetadata.Position = position;
@@ -341,7 +341,7 @@ public async Task<IActionResult> UpdatePosition(string contentItemId, double pos
 
             if (Request.Headers != null && Request.Headers["X-Requested-With"] == "XMLHttpRequest")
             {
-                return StatusCode(200);
+                return Ok();
             }
             else
             {

src/OrchardCore.Modules/OrchardCore.Media/Controllers/AdminController.cs

@@ -280,12 +280,12 @@ public async Task<IActionResult> MoveMedia(string oldPath, string newPath)
 
             if (!_allowedFileExtensions.Contains(Path.GetExtension(newPath), StringComparer.OrdinalIgnoreCase))
             {
-                return StatusCode(StatusCodes.Status400BadRequest, S["This file extension is not allowed: {0}", Path.GetExtension(newPath)]);
+                return BadRequest(S["This file extension is not allowed: {0}", Path.GetExtension(newPath)]);
             }
 
             if (await _mediaFileStore.GetFileInfoAsync(newPath) != null)
             {
-                return StatusCode(StatusCodes.Status400BadRequest, S["Cannot move media because a file already exists with the same name"]);
+                return BadRequest(S["Cannot move media because a file already exists with the same name"]);
             }
 
             await _mediaFileStore.MoveFileAsync(oldPath, newPath);
@@ -385,7 +385,7 @@ public async Task<ActionResult<IFileStoreEntry>> CreateFolder(
 
             if (_invalidFolderNameCharacters.Any(invalidChar => name.Contains(invalidChar)))
             {
-                return StatusCode(StatusCodes.Status400BadRequest, S["Cannot create folder because the folder name contains invalid characters"]);
+                return BadRequest(S["Cannot create folder because the folder name contains invalid characters"]);
             }
 
             var newPath = _mediaFileStore.Combine(path, name);
@@ -399,13 +399,13 @@ public async Task<ActionResult<IFileStoreEntry>> CreateFolder(
             var mediaFolder = await _mediaFileStore.GetDirectoryInfoAsync(newPath);
             if (mediaFolder != null)
             {
-                return StatusCode(StatusCodes.Status400BadRequest, S["Cannot create folder because a folder already exists with the same name"]);
+                return BadRequest(S["Cannot create folder because a folder already exists with the same name"]);
             }
 
             var existingFile = await _mediaFileStore.GetFileInfoAsync(newPath);
             if (existingFile != null)
             {
-                return StatusCode(StatusCodes.Status400BadRequest, S["Cannot create folder because a file already exists with the same name"]);
+                return BadRequest(S["Cannot create folder because a file already exists with the same name"]);
             }
 
             await _mediaFileStore.TryCreateDirectoryAsync(newPath);

src/OrchardCore.Modules/OrchardCore.Setup/Controllers/SetupController.cs

@@ -61,7 +61,7 @@ public async Task<ActionResult> Index(string token)
 
             if (!await ShouldProceedWithTokenAsync(token))
             {
-                return StatusCode(404);
+                return NotFound();
             }
 
             var model = new SetupViewModel

src/OrchardCore.Modules/OrchardCore.Tenants/Controllers/ApiController.cs

@@ -113,7 +113,7 @@ public async Task<IActionResult> Create(CreateApiViewModel model)
 
                     var token = CreateSetupToken(settings);
 
-                    return StatusCode(201, GetEncodedUrl(settings, token));
+                    return Created(GetEncodedUrl(settings, token), null);
                 }
                 else
                 {
@@ -165,7 +165,7 @@ public async Task<ActionResult> Setup(SetupApiViewModel model)
 
             if (shellSettings.State == TenantState.Running)
             {
-                return StatusCode(201);
+                return Created(GetEncodedUrl(shellSettings, null), null);
             }
 
             if (shellSettings.State != TenantState.Uninitialized)
@@ -280,7 +280,7 @@ public async Task<ActionResult> Setup(SetupApiViewModel model)
                     ModelState.AddModelError(error.Key, error.Value);
                 }
 
-                return StatusCode(500, ModelState);
+                return this.InternalServerError(ModelState);
             }
 
             return Ok(executionId);

src/OrchardCore/OrchardCore.Mvc.Core/Extensions/ControllerExtensions.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Net;
 
 namespace Microsoft.AspNetCore.Mvc
 {
@@ -27,6 +28,14 @@ public static ActionResult ChallengeOrForbid(this Controller controller)
         public static ActionResult ChallengeOrForbid(this Controller controller, params string[] authenticationSchemes)
             => controller.User?.Identity?.IsAuthenticated ?? false ? (ActionResult)controller.Forbid(authenticationSchemes) : controller.Challenge(authenticationSchemes);
 
+        /// <summary>
+        /// Creates <see cref="ObjectResult"/> that produces a <see cref="HttpStatusCode.InternalServerError"/> response.
+        /// </summary>
+        /// <param name="controller">The <see cref="Controller"/>.</param>
+        /// <param name="value">An optinal value to set on <see cref="ObjectResult"/>.</param>
+        public static ActionResult InternalServerError(this Controller controller, object value = null)
+            => controller.StatusCode((int)HttpStatusCode.InternalServerError, value);
+
         /// <summary>
         /// Creates a <see cref="LocalRedirectResult"/> object that redirects to the specified local localUrl
         /// </summary>