Update the action bar on manage contents page #12368
Conversation
|
Can we increase the search bar little to make the spacing consistent |
|
@hishamco I made some more changes to the second action bar along with the action bar spacing. check out the updated screenshots |
|
Can we see what the search bar looks like now when width = 100%? |
|
Also, need to see if these UI fixes need to be applied everywhere else. |
|
can you try and add a w-md-50 or w-lg-50 class there. |
| } | ||
| <div class="input-group input-group-sm w-50 d-inline-flex has-filter"> |
There was a problem hiding this comment.
here try w-md-50 or w-lg-50 instead.
There was a problem hiding this comment.
@Skrypt are you fine to merge this without this suggestion?
There was a problem hiding this comment.
@Skrypt if you must have a max width set, we could add w-xxl-75 just for super large screens.
|
I personally think it looks better with 100% width. |
|
I can't argue with taste. If you have a 4k screen it will make a long search input bar. That's why it was added. |
|
Here as an example Github does not use full width:
|
|
I get it. but making it shorter won't add value. |
|
Unless you would need to type long search strings that are equivalent to the full width size of a 4k screen I don't see the added value either. |
|
I'm not sure if I'm the only one see extra space before the new dropdown |
|
Add a screenshot. I can't see it either! 😄 |
|
I think there's two extra pixels before the new dropdown comparing with the spacing after, needs BIG 👀 |
|
I don't see any extra pixels in his screenshots. But beware because these are low-quality screenshots. I can see that it is not using all the colors it should and the compression could add some weird pixels. |
|
@MikeAlhayek could you please inspect the spacing before and after the new dropdown? It looks good but that's why designer is better than devs because they taking care about each pixel :) |
|
@hishamco I did not add a drop down menu. Can you show us where are you pointing to? I would say share a screen shot with the develops so that they can see through a designer eyes :) |
|
The filter button? Which has a dropdown menu? |
|
I just measure the spaces before and after the new dropdown seems the quality here as @Skrypt mentioned, both are 16 px, so seems I need to close my eyes ;) |
|
@MikeAlhayek could you please check tenants page? I remembered I saw similar issue |
|
@hishamco yea same problem exists in multiple pages. I want to focus on Contents module for now, once all agree on the change and is merged, I'll apply the same on the rest like OC.Tenant, OC.Features and possibly others. |
|
We already agreed ;) I might help you on this Thanks |
|
@MikeAlhayek I just waiting for @Skrypt to reply on my above comment meanwhile could you please file an issue list all the places that we need to modify the action bar, this will make it easy for tracking and I can help you on this especially if it has a long list |
|
Combined into #12421 |
|
I'm not sure why closed the PRs, small manageable PRs always good |
Fix #12367
Web view
Here is a before screenshot
Here is an after screenshot
Mobile view
Here is a before screenshot
Here is an after schreenshot
