Fixing NRE when publishing item with LocalizationPart removed (Lombiq Technologies: OCORE-102) #12401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested changes
Sep 13, 2022
| @@ -101,7 +101,7 @@ public void Describe(DescribeContext<ContentItem> context) | |||
| return new LocalizedContentItemIndex | |||
| { | |||
| Culture = !partRemoved ? part.Culture.ToLowerInvariant() : null, | |||
There was a problem hiding this comment.
We can reduce the number of checks to one
if (partRemoved)
{
Culture = LocalizationSet = null;
}
else
{
Culture = part.Culture.ToLowerInvariant();
LocalizationSet = part.LocalizationSet;
}There was a problem hiding this comment.
This is inside an object initializer so we can't do that. If we want to reduce the number of ifs then from line 101 this has to be broken up with an object initializer, then conditional assignment, then return part, which looks a lot messier.
There was a problem hiding this comment.
Oops, I saw the object initializer now ;) forget my comment
There was a problem hiding this comment.
No worries! Thanks for reviewing.
hishamco
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like an oversight since line 103 handles this in the same
LocalizedContentItemIndexProvider.