Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Autoroute part UI #12454

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

MikeAlhayek
Copy link
Member

Updating the setting UI for the Autoroute settings

After the change screenshots

image

image

Before the change screenshots

image

@hishamco
Copy link
Member

Do we really needs all these changes for adding a space ;)

@MikeAlhayek
Copy link
Member Author

It's adding a space and also allow the show/hide as the code was intended.

@@ -99,5 +100,5 @@
checked ? $(this).show() : $(this).hide();
});
});
//]]>
//]]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//]]>
//]]>

@hishamco
Copy link
Member

It's adding a space and also allow the show/hide as the code was intended.

So, I will leave this to Jasmin

@sebastienros sebastienros merged commit b70de62 into OrchardCMS:main Sep 22, 2022
@MikeAlhayek MikeAlhayek deleted the FixAutoroutPartUI branch December 28, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants