Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change query schema editor to monaco-editor #12458

Merged
merged 9 commits into from
Sep 22, 2022

Conversation

hyzx86
Copy link
Contributor

@hyzx86 hyzx86 commented Sep 20, 2022

image

@hyzx86

This comment was marked as outdated.

@hyzx86
Copy link
Contributor Author

hyzx86 commented Sep 20, 2022

@hishamco @Skrypt Can you help me look at this problem?

@Skrypt
Copy link
Contributor

Skrypt commented Sep 20, 2022

No adjustment can make the editor effective on this page

Can we see a screencast of the actual issue to define what it is?

@hyzx86

This comment was marked as outdated.

@hyzx86

This comment was marked as resolved.

@hyzx86

This comment was marked as resolved.

@hyzx86 hyzx86 marked this pull request as ready for review September 20, 2022 15:50
Copy link
Member

@hishamco hishamco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the format in every PR, also share a screen cast as @Skrypt suggested

@Skrypt Skrypt merged commit 5c3ceaf into OrchardCMS:main Sep 22, 2022
@hyzx86 hyzx86 deleted the fix_schemaToMonaco branch June 13, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants