Fix content types fields dependency #12492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… field definitions, but not allow editing of an old (attached) field
|
@jtkech are you okay with me merging this PR? |
hishamco
requested changes
Oct 20, 2022
src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.ContentTypes/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.ContentTypes/Views/Admin/Edit.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.ContentTypes/Views/Admin/Edit.cshtml
Outdated
Show resolved
Hide resolved
…dminController.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
…dminController.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
…dminController.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
…dit.cshtml Co-authored-by: Hisham Bin Ateya <[email protected]>
hishamco
approved these changes
Oct 20, 2022
|
@hishamco I updated the PR with screenshots. I am checking out a different PR, if you want to do more testing, please fork this PR and test it out or evaluate it locally. Not planning any additional changes, unless someone spots a bug that I missed. |
jtkech
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12488
The button shows up when at least 1 field definition is available.
A field was previously added to the content items. but there are no more field definition registred, so we allow removing previously attached fields but there is no Add Fields button
There is no content fields available, so we hide the button
