Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field wrappers #12495

Merged
merged 6 commits into from
Oct 6, 2022
Merged

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Sep 24, 2022

In PR #12347 I added css class wrapper to content fields to allow us to use JS to hide/show fields. However, the class name we used for the wrapper is not unique since the same name can be used on multiple parts. To make it unique, I am adding part name to make it unique. This PR makes the class name as field-wrapper-partname-fieldname instead of field-wrapper-fieldname

@MikeAlhayek
Copy link
Member Author

@sebastienros the names were updated based on the feedback from triage

@sebastienros sebastienros merged commit b5db66a into OrchardCMS:main Oct 6, 2022
@MikeAlhayek MikeAlhayek deleted the FixFieldWrappers branch December 28, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants