Remove hard coded HTML Ids from UserFields.Edit.cshtml to allow reusing it

[MikeAlhayek]

Replace hard coded HTML ids with generated ID to allow the reuse of UserFields.Edit.cshtml

Fix #12531

[Skrypt]

Looks fine to me.

[hishamco]

@Skrypt I didn't see such thing before in our code base, we already bound to the property name

[Skrypt]

No, it is not consistent with what we generally do, I agree. Though, a specific use case here seems to be fine to use. Though, he could have overridden the Razor template in its own Theme for that matter without breaking anything. So, it is debatable.

[MikeAlhayek]

@hishamco yes may be this isn't consistent with what we generally do. IMO, since a view is called in a driver, it should be reusable so hard coding HTML ids is not a good idea as I learned :)

@Skrypt yes I can override this view in my own theme "this is what I do today as a workaround". But I thought, we should also make this view robust in OC since it's called from drivers.

Either way, I change the code in the view to make it more robust by removing the hard coded HTML ids completely, and use css classes. This way the Javascript code actually is called with no problem for every instance rendered on the HTML page.

[hishamco]

Though, he could have overridden the Razor template in its own Theme for that matter without breaking anything

That's what supposed to be done, I diagree for adding things that's help user needs, where we provide an extensibility point for that

Let us hear the feedback from others