Remove extra spacing around editing contents, flows and bag part #12585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @Skrypt this is what I am referring to. I updated the PR with some screenshots |
Skrypt
reviewed
Nov 1, 2022
| data-contenttypes-name="@Model.ContentTypesName" | ||
| data-contentitems-name="@Model.ContentItemsName" | ||
| data-widget-type="@type.Name" | ||
| href="javascript:;">@type.DisplayName</a></li> |
There was a problem hiding this comment.
I assume that you used VS auto-formatting here. Maybe that's not the best.
Skrypt
reviewed
Nov 1, 2022
src/OrchardCore.Modules/OrchardCore.Flows/Views/FlowPart.Edit.cshtml
Outdated
Show resolved
Hide resolved
Skrypt
reviewed
Nov 1, 2022
src/OrchardCore.Modules/OrchardCore.Flows/Views/FlowPart.Edit.cshtml
Outdated
Show resolved
Hide resolved
| <div class="btn-group"> | ||
| @if (Model.CanInsert != false) | ||
| @if (Model.CanInsert) |
There was a problem hiding this comment.
This looks like it's broken the View (in some cases, not sure which ones yet)
But Model.CanInsert is genearlly a null, so it can't be cast to a bool
There was a problem hiding this comment.
If that's the case then it should be set properly as a bool beforehand in the Driver or we should be using a strongly type ShapeViewModel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some screenshots of the adjusted spacing
removed extra spacing around bag part, widget list and flow part
Removed the extra spacing around the create/edit form in contents and the page title
Here are screenshots from the past (as you can see the spacing isn't consistent)
This is a good view. I am positing here just so you can see that the spacing are not consistent with the above screenshot.
