Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlParser & SqlGrammar subquery support #12645

Merged
merged 8 commits into from
Oct 20, 2022

Conversation

lampersky
Copy link
Contributor

fixes #11785

example query:

select * from (
    select d as e from (
        select c as d from (
            select b as c from (
                select a as b from t
            ) as l4
        ) as l3
    ) as l2
) as l1;

(this PR also includes changes from #12637 CTE support)

/cc @sebastienros

}
_builder.Append(columns[j].Token.ValueString);
}
_builder.Append(")");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you forgot to fix this

Copy link
Member

@hishamco hishamco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but again we might need spend some time to replace Irony with fresh SqlParser built on top of Parlot

@sebastienros sebastienros merged commit 6cb1e83 into OrchardCMS:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL SELECT FROM subquery not available
3 participants