Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for YesSQL breaking change #12681

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Add documentation for YesSQL breaking change #12681

merged 2 commits into from
Oct 25, 2022

Conversation

Skrypt
Copy link
Contributor

@Skrypt Skrypt commented Oct 21, 2022

Fixes #12653, Fixes #12679

@Skrypt Skrypt enabled auto-merge (squash) October 21, 2022 17:48
@Skrypt Skrypt disabled auto-merge October 21, 2022 17:48
@Skrypt
Copy link
Contributor Author

Skrypt commented Oct 21, 2022

Weird licence/cla limitation.

hishamco
hishamco requested changes Oct 21, 2022
View reviewed changes
src/docs/releases/1.5.0.md Outdated Show resolved Hide resolved
@Skrypt
Copy link
Contributor Author

Skrypt commented Oct 21, 2022

Anyone else than me can merge this?

@hishamco hishamco mentioned this pull request Oct 22, 2022
Merged
@ns8482e
Copy link
Contributor

ns8482e commented Oct 23, 2022 •
edited
Loading

Weird licence/cla limitation.

@Skrypt It seems something broken(may be auth) between dnf cla service and orchard cms org

@Skrypt
Copy link
Contributor Author

Skrypt commented Oct 23, 2022

I just tested this here with Elsa and it works:
elsa-workflows/elsa-core#3379

So, it is something broken with our CI or our Github config.

@jtkech
Copy link
Member

jtkech commented Oct 23, 2022

@Skrypt

About the cla maybe related to github settings of the repo, would need to have access rights.

After reading some related issues, try to merge dev in your branch and push it to see if it unlocks this cla check, maybe it needs to be in sync with the last dev whose last commits are not marked as verified.

Not sure at all, just an idea ;)

@Skrypt Skrypt added this to the 1.5 milestone Oct 23, 2022
@ns8482e
Copy link
Contributor

ns8482e commented Oct 23, 2022 •
edited
Loading

This status you get for previously successful pr

Error
There is no CLA to sign for OrchardCMS/OrchardCore

({"message":"Bad credentials","documentation_url":"https://docs.github.com/rest"})

https://cla.dotnetfoundation.org/OrchardCMS/OrchardCore?pullRequest=12671

@jtkech
Copy link
Member

jtkech commented Oct 23, 2022

Oops

@Skrypt
Copy link
Contributor Author

Skrypt commented Oct 23, 2022

hmm ok, this is not good. How can the license from DNF disappear like this?

@sebastienros sebastienros changed the base branch from main to release/1.5 October 25, 2022 19:27
@sebastienros sebastienros merged commit ab8701a into release/1.5 Oct 25, 2022
@sebastienros sebastienros deleted the skrypt/#12653 branch October 25, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeAlhayek MikeAlhayek MikeAlhayek approved these changes

@hishamco hishamco hishamco approved these changes

@agriffard agriffard Awaiting requested review from agriffard agriffard is a code owner

@sebastienros sebastienros Awaiting requested review from sebastienros

@jtkech jtkech Awaiting requested review from jtkech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5
6 participants
@Skrypt @ns8482e @jtkech @hishamco @MikeAlhayek @sebastienros