Indexing Latest not working as intended #12691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I won't be able to merge that one either. There is an issue with the licence/cla with every new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12690
This should do it. I thought a StoredField would be enough to find these documents in the indices but seems like it is not.
The other issue is that I refactored the LuceneIndexManager to make it a little faster and made a mistake on the value that should be stored in the dictionary to retrieve a Draft. Seems like we never really use the ContentItemVersionId when indexing. We just take the latest one or the published one and we prune any document indexed related to a ContentItemId before updating with new documents.