-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Localization settings #13181
User Localization settings #13181
Conversation
src/OrchardCore.Modules/OrchardCore.Users/Localization/UserLocalizationStartup.cs
Outdated
Show resolved
Hide resolved
Let me know if you agree with the suggested change and then if it still works, so that I can approve. |
...chardCore.Modules/OrchardCore.Users/Localization/Providers/UserLocalizationClaimsProvider.cs
Outdated
Show resolved
Hide resolved
...e.Modules/OrchardCore.Users/Localization/Providers/UserLocalizationRequestCultureProvider.cs
Outdated
Show resolved
Hide resolved
...e.Modules/OrchardCore.Users/Localization/Providers/UserLocalizationRequestCultureProvider.cs
Outdated
Show resolved
Hide resolved
...e.Modules/OrchardCore.Users/Localization/Providers/UserLocalizationRequestCultureProvider.cs
Outdated
Show resolved
Hide resolved
...e.Modules/OrchardCore.Users/Localization/Providers/UserLocalizationRequestCultureProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/Localization/UserLocalizationStartup.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/Localization/UserLocalizationStartup.cs
Outdated
Show resolved
Hide resolved
I think I will wait for tomorrow to continue on this. It doesn't work anyways. The |
@Skrypt if you want me to continue on this today let me know> I know the time zone difference sometime has pros & cons ;) |
4:15 am I'm going back to sleep guys. Have fun! 😉 |
I might add some commits if you don't mind |
Try it first. Then make the changes. |
...e.Modules/OrchardCore.Users/Localization/Providers/UserLocalizationRequestCultureProvider.cs
Outdated
Show resolved
Hide resolved
...e.Modules/OrchardCore.Users/Localization/Providers/UserLocalizationRequestCultureProvider.cs
Outdated
Show resolved
Hide resolved
...e.Modules/OrchardCore.Users/Localization/Providers/UserLocalizationRequestCultureProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/Localization/UserLocalizationStartup.cs
Outdated
Show resolved
Hide resolved
@Skrypt did the authorization issue still happening? |
Yes, it needs to be figured out properly. Don't merge anything yet. I have really low time to spend on this but you get the idea for now. |
No worry, I will not, but I'm asking about the progress of this one in case if you need a help |
@Skrypt do you have a time to finalize this before |
Depends when we release 1.6 |
Seems there's only one lucene issue left, which we are waiting for our lucene guru to fix it :) |
Hisham, would you like to take over? |
Awesome! |
@hishamco all yours. |
src/OrchardCore.Modules/OrchardCore.Users/Localization/Drivers/UserLocalizationDisplayDriver.cs
Show resolved
Hide resolved
@Skrypt is there anything else to add or shall I do a final review? |
I was thinking about unit tests. Never take time to do them. |
I can do them if the PR is ready now |
src/OrchardCore.Modules/OrchardCore.Users/Localization/Constants.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Zoltán Lehóczky <[email protected]>
…ub.com/OrchardCMS/OrchardCore into skrypt/admin-user-localization-setting
This pull request has merge conflicts. Please resolve those before requesting a review. |
# Conflicts: # src/docs/releases/1.9.0.md
Should we merge this or wait for unit tests? @Piedone anything else to add here on this PR? |
Please re-request review next time (top-right corner) so I can know you're done. |
Co-authored-by: Zoltán Lehóczky <[email protected]>
src/OrchardCore.Modules/OrchardCore.Users/Localization/ViewModel/UserLocalizationViewModel.cs
Outdated
Show resolved
Hide resolved
…el/UserLocalizationViewModel.cs Co-authored-by: Sébastien Ros <[email protected]>
src/OrchardCore.Modules/OrchardCore.Users/Localization/Drivers/UserLocalizationDisplayDriver.cs
Outdated
Show resolved
Hide resolved
…/UserLocalizationDisplayDriver.cs Co-authored-by: Sébastien Ros <[email protected]>
Adds User Localization settings.
Also adds a RequestCultureProvider based on claims. This provider will take precedence over any existing ones allowing to override browser settings and always displaying with unique culture for that user. This is not a User Culture Picker for the frontend but a way to set the culture to a prefered one for each users. A User Culture Picker would be another RequestCultureProvider with a higher priority than this one. This is why I think we need to have this in the Core.