-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to allow the user to change the full-text search behavior in the Contents admin UI. #13919
Add an option to allow the user to change the full-text search behavior in the Contents admin UI. #13919
Conversation
…or in the admin UI. Fix OrchardCMS#13886
src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListQueryService.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListQueryService.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListQueryService.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Contents.Core/ContentSearchOption.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Contents.Core/ContentSearchOption.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Contents.Core/ContentSearchOption.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListQueryService.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Contents.Core/ContentSearchOption.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListQueryService.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListQueryService.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Contents.Core/ContentsAdminListFilterOptions.cs
Outdated
Show resolved
Hide resolved
I did another review LGTM but maybe worth to be able to also define the default operator, hmm as I remember we also needed to define a full quoted string because when searching for But I'm not against if we agree that it could be done in separate PRs. |
made some more changes and added double-quotes. Let me know if you see anything else. |
src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListQueryService.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListQueryService.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListQueryService.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListQueryService.cs
Outdated
Show resolved
Hide resolved
Okay, let @sebastienros decide which options are worth to support, maybe also the default operation, and the Maybe the options would need to be able to return a full In my case I was checking if there is no explicit operator in use, maybe we don't need this, just take into account the current options, but not sure, would need to focus on it more. |
@jtkech I added |
Does it work? As I remember it was not working when I tried it, but not sure now I don't like the |
src/OrchardCore/OrchardCore.Contents.Core/ContentsAdminListFilterOptions.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Contents.Core/ContentsAdminListFilterOptions.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Contents.Core/ContentsAdminListFilterOptions.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Contents.Core/ContentsAdminListFilterOptions.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Contents.Core/ContentsAdminListFilterOptions.cs
Outdated
Show resolved
Hide resolved
@jtkech I renamed |
src/OrchardCore.Modules/OrchardCore.Contents/Services/DefaultContentsAdminListQueryService.cs
Outdated
Show resolved
Hide resolved
@jtkech let me know if you see anything need changes or approve it please. |
Okay, I will look at it this night, I may do some last minor changes and then approve (or merge). |
Okay, I did some last changes and approved, I let you review my changes |
Fix #13886