-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3 #14256
base: main
Are you sure you want to change the base?
Vue 3 #14256
Conversation
# Conflicts: # src/docs/resources/libraries/README.md
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Resources/package-lock.json # src/OrchardCore.Modules/OrchardCore.Resources/package.json
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.js # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.min.js # src/OrchardCore.Modules/OrchardCore.Resources/package-lock.json # src/OrchardCore.Modules/OrchardCore.Resources/package.json
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.js # src/OrchardCore.Modules/OrchardCore.Resources/package-lock.json # src/OrchardCore.Modules/OrchardCore.Resources/package.json # src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/trumbowyg-plugins.js # src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/trumbowyg-plugins.min.js # src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Styles/trumbowyg-plugins.css # src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Styles/trumbowyg-plugins.min.css # src/docs/resources/libraries/README.md
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.js # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.min.js
remove depends-on="admin"
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Resources/package.json
This pull request has merge conflicts. Please resolve those before requesting a review. |
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Resources/package-lock.json # src/OrchardCore.Modules/OrchardCore.Resources/package.json
This pull request has merge conflicts. Please resolve those before requesting a review. |
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
Of course bot I will pick it up at some time in the future 😄 |
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Media/ResourceManifestOptionsConfiguration.cs # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.js # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.min.js # src/OrchardCore.Modules/OrchardCore.Resources/Assets.json # src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/trumbowyg-plugins.js # src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/trumbowyg-plugins.min.js # src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Styles/trumbowyg-plugins.min.css # src/docs/resources/libraries/README.md
This pull request has merge conflicts. Please resolve those before requesting a review. |
for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment. |
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
The current state of this is that I'm refactoring the entire thing with Typescript and Uppy. Also one thing that doesn't work quite well is the fact that we are generating a TSClient.ts with NSwagStudio and by default OC doesn't have any Swagger endpoint. I remember that we decided back then to not include anything by default in OC. There would be some work to do also on the response produced by ApiControllers. I remember that I got stuck at one point where I was trying to also refactor the build tool in OC to use something a little more up to date. The issue is that now everything Vue should be bundled with "Vite" but we also need to support legacy apps and also webpack. |
Thanks for the update! |
Happy to support that from our end.
I would suggest not trying to use a generated client here. Obviously I have an nswag module, which is fine to use, or bring into OC, but it doesn't fix the above problem. |
I can generate the client and remove what is not needed for the file app manually. But, yeah, that's a downside. |
Work in progress.
The goal here is first to migrate all the components and SFC to Vue 3. We cannot use
new Vue
with Vue 3 so some components will need to be refactored.Also, the components dynamic loading methods need to be removed in favor of using a wrapping component with props simply. Favor usage of Vite with Vue 3 apps/components.
Tasks
Fixes #7110.
Optional
Consider refactoring upload bits by using Uppy instead of JQuery FileUpload as it is now archived and old.
See:
https://uppy.io/
https://tus.io/
https://github.com/tusdotnet/tusdotnet
https://www.ietf.org/archive/id/draft-tus-httpbis-resumable-uploads-protocol-00.html