Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WorkflowType extension able #14275

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Make WorkflowType extension able #14275

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed8bd06
make WorkflowType Extension able
hyzx86 Sep 5, 2023
d43f342
Merge branch 'OrchardCMS:main' into WorkflowTypeExtensionAble
hyzx86 Sep 5, 2023
bb8718a
make WorkflowType Extension able
hyzx86 Sep 5, 2023
6918721
Merge branch 'WorkflowTypeExtensionAble' of https://github.com/hyzx86…
hyzx86 Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/OrchardCore/OrchardCore.Workflows.Abstractions/Models/WorkflowType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
using System.Collections.Generic;
using OrchardCore.Entities;

namespace OrchardCore.Workflows.Models
{
/// <summary>
/// Represents a workflow type.
/// </summary>
public class WorkflowType
public class WorkflowType : Entity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe IEntity would have been sufficient

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtkech IEntity would have been sufficient but then you would have to implement it. Entity provides a default implementation to IEntity

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then

{
public long Id { get; set; }

Expand Down