Add IdentityErrorCode #14332
Closed
Add IdentityErrorCode #14332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public class IdentityErrorCode | ||
| { | ||
| public const string PasswordRequiresDigit = nameof(PasswordRequiresDigit); |
There was a problem hiding this comment.
I don't even agree with the technicality of these changes and using nameof everywhere because the day we decide to change the property name, even in casing, then it will break the underlying behavior or localization.
There was a problem hiding this comment.
Would be fine if it was just public const string PasswordRequiresDigit = "PasswordRequiresDigit" but we don't even need it, the string is not used anywhere else, no need to synchronize them.
There was a problem hiding this comment.
What about creating private class? If No, you can close the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I'm working on #14331 , I notice there's no need for the magic string