Add Cacheable Entity

[MikeAlhayek]

The interface ICacheableEntity provides a way to cache properties in IEntity. This will improve the speed of retrieving the settings from SiteService.

@sebastienros brought up this issue during the call today.

@jtkech thoughts on this approach?

In this current approach, a new ICacheableEntity interface was added. The idea is to make IEntity cacheable when needed. If you need (you should in most cases) IEntity, then implement ICacheableEntity instead of IEntity or inherit from CacheableEntity instead of Entity.

If we want to make IEntity cacheable all the time, we can simply drop the new ICacheableEntity interface, and move it's methods to IEntity instead. I just don't know if using cache for everything by default is a good idea. Maybe it is, I am just not very convinced. if @sebastienros and @jtkech think it's appropriate, I can simplify by removing ICacheableEntity.

[MikeAlhayek]

@sebastienros I am moving the discussion here. In your comment you stated the following

Wouldn't it be simpler to just add methods to IEntity and have existing classes implement it?
But I will think more about this new interface, maybe it's the name that bothers me.

You may be able to suggest better one. Ideas?

The problem adding a new property on IEnitity is that we may need an entity that isn't cacheable. I don't know if we need an IEnitity that does not use cache. we already have any classes that implement the IEntity like DocumentEntity and Entity.

But if you think IEnitity should be cacheable everywhere, I can move the 3 methods into IEntity

void Set(string key, object value);
void Forget(string key);
object Get(string key);

[jtkech]

@jtkech thoughts on this approach?

Okay, will look at it when I will have time.

[hishamco]

I think you need to let DocumentEntity implements ICacheableEntity instead, so all the implementation will be no long exist here

[MikeAlhayek]

Not sure we want that behavior applied everywhere. If that is the cache, we can just remove ICacheableEntity and move the new methods into IEntity instead. Look at the notes in the description of the PR.

[hishamco]

@MikeAlhayek, please check my changes

[MikeAlhayek]

@hishamco not a fan of the changes.

[hishamco]

Check my comment, otherwise I will revert my changes :)

[MikeAlhayek]

@hishamco I left you comments on the changes you made please visit them so we can finalize the PR.

[hishamco]

I might let @jtkech review this PR too if he has a time