Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdminBranding #14453

Merged
merged 1 commit into from
Oct 8, 2023
Merged

AdminBranding #14453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/OrchardCore.Modules/OrchardCore.Admin/Views/AdminBranding.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@inject IOptions<AdminOptions> AdminOptions
<link asp-src="~/OrchardCore.Admin/favicon.ico" type="image/x-icon" rel="shortcut icon" />

<zone name="HeadMeta">
<link asp-src="~/OrchardCore.Admin/favicon.ico" type="image/x-icon" rel="shortcut icon" />
</zone>
<a class="ta-navbar-brand navbar-brand" href="@Url.Content("~/" + AdminOptions.Value.AdminUrlPrefix)">
<div class="d-flex align-items-center">
<img src="@Url.Content("~/OrchardCore.Admin/logo.png")" alt="@Site.SiteName" class="pe-2" />
Expand Down
23 changes: 15 additions & 8 deletions src/docs/reference/modules/Admin/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ If you want to specify another prefix in the urls to access the admin section, y

By default, OrchardCore logo and site name are displayed in the top navbar.

You can change it by overriding 'AdminBranding' shape, either from a [custom admin theme](../../../guides/create-admin-theme/README.md) or using Admin Templates feature.
You can change it by overriding 'AdminBranding' shape, either from a [custom admin theme](../../../guides/create-admin-theme/README.md) or using Admin Templates feature.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra whitespace at the end

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is on purpose: Double spaces force to the next sentence to be on a new line.

It currently lokks like this:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange!!

You can also use this shape to define admin favicon.

Here are samples using logo and favicon from media module.
Expand All @@ -26,20 +26,27 @@ Here are samples using logo and favicon from media module.

``` liquid
{% assign favicon_url = 'favicon.ico' | asset_url %}
{% link rel:'shortcut icon', type:'image/x-icon', src:favicon_url %}
{% zone "HeadMeta" %}
{% link rel:'shortcut icon', type:'image/x-icon', src:favicon_url %}
{% endzone %}
{% a area: 'OrchardCore.Admin', controller: 'Admin' , action: 'Index', class: 'ta-navbar-brand' %}
<img src="{{ 'logo.png' | asset_url }}" alt="{{ Site.SiteName }}" />
<span>{{ Site.SiteName }}</span>
<div class="d-flex align-items-center">
<img src="{{ 'logo.png' | asset_url }}" alt="{{ Site.SiteName }}" class="pe-2" />
<span>{{ Site.SiteName }}</span>
</div>
{% enda %}
```

=== "Razor"

``` html
<link asp-src="~/media/favicon.ico" type="image/x-icon" rel="shortcut icon" />

<zone name="HeadMeta">
<link asp-src="~/media/favicon.ico" type="image/x-icon" rel="shortcut icon" />
</zone>
<a class="ta-navbar-brand" asp-route-area="OrchardCore.Admin" asp-controller="Admin" asp-action="Index">
<img [email protected]("~/media/logo.png") alt="@Site.SiteName" />
<span>@Site.SiteName</span>
<div class="d-flex align-items-center">
<img [email protected]("~/media/logo.png") alt="@Site.SiteName" class="pe-2" />
<span>@Site.SiteName</span>
</div>
</a>
```