Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw descriptive exception when a field is added with no type. #14569

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Throw descriptive exception when a field is added with no type. #14569

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c04909
Throw descriptive exception when a field is added with no type.
MikeAlhayek Oct 23, 2023
90d484e
use InvalidOperationException
MikeAlhayek Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/OrchardCore/OrchardCore.ContentManagement/ContentDefinitionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,11 @@ private static void Apply(ContentPartDefinition model, ContentPartDefinitionReco
var partFieldRecord = record.ContentPartFieldDefinitionRecords.FirstOrDefault(r => string.Equals(r.Name, fieldName, StringComparison.OrdinalIgnoreCase));
if (partFieldRecord == null)
{
if (field.FieldDefinition == null)
{
throw new Exception($"The '{field.Name}' field in '{model.Name}' part was defined without a specified type. Please review the migration and explicitly specify the field type.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new Exception($"The '{field.Name}' field in '{model.Name}' part was defined without a specified type. Please review the migration and explicitly specify the field type.");
throw new InvalidOperationException($"The field type for '{field.Name}' is not specified.");

}

partFieldRecord = new ContentPartFieldDefinitionRecord
{
FieldName = field.FieldDefinition.Name,
Expand Down
Loading