Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing connection dispose #14709

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Missing connection dispose #14709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OrchardCore.Modules/OrchardCore.Queries/Sql/Controllers/AdminController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public async Task<IActionResult> Query(AdminQueryViewModel model)
var stopwatch = new Stopwatch();
stopwatch.Start();

var connection = _store.Configuration.ConnectionFactory.CreateConnection();
await using var connection = _store.Configuration.ConnectionFactory.CreateConnection();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it awaited?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hishamco At the end of an using var disposable it calls disposable.Dispose().

At the end of an await using var disposable it calls await disposable.DisposeAsync().

But you can do that only if disposable is an IAsyncDisposable.

var dialect = _store.Configuration.SqlDialect;

var parameters = JsonConvert.DeserializeObject<Dictionary<string, object>>(model.Parameters);
Expand Down