Use RequestLocalizationOptions.CultureInfoUseUserOverride

[hishamco]

dotnet/aspnetcore#44282

[jtkech]

Okay looks good, I will approve.

But please only merge if you have retried it.

Hmm, I think we can just remove LocalizationOptionsUpdater but as you want.

Good job!

[hishamco]

Hmm, I think we can just remove LocalizationOptionsUpdater but as you want.

I'm not sure if we can remove it now or not, it'll be a breaking change or shall we remove it because it's only used inside the module and the release note is enough

[hishamco]

Seems there's no need for the LocalizationOptionsUpdater changes, right? I did it before I rid off the use of LocalizationOptionsUpdater

[jtkech]

We should merge this one.

I'm not sure if we can remove it now or not, it'll be a breaking change or shall we remove it because it's only used inside the module and the release note is enough

Yes I think you can just remove LocalizationOptionsUpdater, then I will merge.

As a side note, would have been less confusing to have a config value with the same name and same logic as UseUserOverride, I think we used IgnoreSystemSettings to have a default value of false, but it's possible to read a boolean from the config and having a default value of true if not specified.

[jtkech]

@hishamco

I removed LocalizationOptionsUpdater and merged your PR.

Notice that I didn't add myself as a co-author ;)

[hishamco]

Believe it or not, the co-author it doesn't matter to me :) it seems next time I will open my eyes during the merge to avoid such an issue :)