Multi TFMs build #14738
Multi TFMs build #14738
Conversation
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| <!-- TFMs used to build the abstractions and modules, by convention the default TFM is at the first position --> | |||
| <!-- In a cross-targeting build, some assets are only copied on the first TFM, by convention the default TFM --> | |||
| <CommonTargetFrameworks Condition="'$(CommonTargetFrameworks)' == ''">net8.0</CommonTargetFrameworks> | |||
| <CommonTargetFrameworks Condition="'$(CommonTargetFrameworks)' == ''">net8.0;net7.0;net6.0</CommonTargetFrameworks> | |||
There was a problem hiding this comment.
Did we bring the previous versions back?
There was a problem hiding this comment.
No ;) This for testing race conditions
There was a problem hiding this comment.
I see, but why the previous TFM are there?
There was a problem hiding this comment.
Because race conditions happen when building multiple TFMs at the same time
|
@sebastienros just for info I know that you are investigating on this issue and possible other ones but I did some tests in this PR. I had different issues, one of them when generating xml files on So for now I think we better have to always copy translation files without any condition knowing that we skip unchanged files. Note: Would be good that they provide a property accessible by inner projects, to know that we are building an inner project. |
|
@jtkech I updated my PR, then looked at this one, and I see you are arriving to the same conclusion as me. So many hours just for that ;) |
|
No problem, it was interesting, yes they should provide a property accessible by inner projects, to know that we are building an inner project, but that's fine to "always" copy translation files. |
|
Close, see #14732 |
@sebastienros
As commented in #14732, if we apply #14732 and if we support multiple TFMs, when building by specifying a TFM it only copy the translation files if the specified TFM is the last one.
So here I tried the following changes, maybe worth to try them on your machine
Here we don't set our
IsCrossTargetedBuildin a props file but through a new Target.This new Target is not called when the Tests project is built, so our custom property is not set in this context. In this context the translation files are copied per TFM but it was the case before.
Then I simplified the condition of the Target copying the translations files.
If it doesn't fix the issue, I suggest to just copy the files per TFM by removing the condition, I don't think that it really matters as we skip unchanged files.
Note: In this PR I re-added net7.0 so that it is easier to test, will need to be removed if we apply it.