-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full type name for Lucene lock type #14805
Conversation
In net9.0 the runtime now exposes it's own `Lock` type, dotnet/runtime#87672. This causes a build break as there is a collision between the Lucene type and the runtime type.
src/OrchardCore.Modules/OrchardCore.Search.Lucene/Services/LuceneIndexManager.cs
Outdated
Show resolved
Hide resolved
30d75f7
to
79d4f99
Compare
I added an alias for |
Does this change look good? |
I think the change should be in lock only |
If the change is limited to just the one that you requested you can't build the project and get this error
This is why I made the change to add the alias for the |
src/OrchardCore.Modules/OrchardCore.Search.Lucene/Services/LuceneIndexManager.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Search.Lucene/Services/LuceneIndexManager.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Search.Lucene/Services/LuceneIndexManager.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Search.Lucene/Services/LuceneIndexManager.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Search.Lucene/Services/LuceneIndexManager.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Search.Lucene/Services/LuceneIndexManager.cs
Outdated
Show resolved
Hide resolved
…eneIndexManager.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
…eneIndexManager.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
…eneIndexManager.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
…eneIndexManager.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
…eneIndexManager.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
In net9.0 the runtime now exposes it's own
Lock
type, dotnet/runtime#87672. This causes a build break as there is a collision between the Lucene type and the runtime type.