Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose ZStringWriter #14933

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Dispose ZStringWriter #14933

merged 1 commit into from
Dec 21, 2023

Conversation

sebastienros
Copy link
Member

No description provided.

@sebastienros
Copy link
Member Author

@lahma

lahma
lahma approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, Dispose() happens after ToString()

@sebastienros
Copy link
Member Author

OrchardCore will fly after this PR is merged

@sebastienros sebastienros merged commit 5e0c994 into main Dec 21, 2023
3 checks passed
@sebastienros sebastienros deleted the sebros/zsrting branch December 21, 2023 20:00
@lahma
Copy link
Contributor

lahma commented Dec 21, 2023

There's also switches for getting the writer like not being nested (single call site like this) and whether UTF-8 is enough. But this should be good enough.

@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Closed
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
@sebastienros @urbanit
Dispose ZStringWriter (OrchardCMS#14933)
8d17dcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastienros @lahma