Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PagerAsync and PagerSlimAsync instead of using dynamic New #14978

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

MikeAlhayek
Copy link
Member

No description provided.

@Skrypt
Copy link
Contributor

Skrypt commented Jan 3, 2024

I'm assuming this is coming from a discussion you had with @sebastienros ?

@MikeAlhayek
Copy link
Member Author

@Skrypt previously @sebastienros has comments about not using dynamic New. Since we have nice extensions for pager, it better to use them to reduce the dynamic call in the code.

This cleans up the code and make it a bit more readable.

Do you see an issue with the PR?

@Skrypt
Copy link
Contributor

Skrypt commented Jan 4, 2024

No issue, just asking.

@MikeAlhayek MikeAlhayek merged commit 87f7a43 into main Jan 4, 2024
3 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/use-pager branch January 4, 2024 21:02
giannik pushed a commit to giannik/OrchardCore that referenced this pull request Jan 7, 2024
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants