-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring Azure Search AI from UI or appsettings. #15004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bleroy I updated the instruction if you already read them. Here is how you can setup your own instance settings In the appsettings, you may enable the configuration globally by adding this
Please let me know if you are able or not to test this PR out. |
Thanks, I'll try it sometime today or tomorrow. I'm not sure I'll be able to test MI just yet though. |
hishamco
pushed a commit
that referenced
this pull request
Feb 1, 2024
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bleroy
Made few changes here. Now you may provide settings for your Azure Search AI via UI and/or appsettings. By default, we require the user to provide service info via the UI by navigating to
Configurations
>>Azure AI Search
.I also added (untested) support for managed-identity for Azure Search AI. You can toggle between
Default
andAPI Key
authentication type from the UI. If you are able to, can you please check out this PR and test drive it with your settings? Please test both API Key andDefault
I have not tested theDefault
type as I do not have an instances that user managed-identity.Also, I believe I fixed the issue you encountered here #14984 (comment)
Lastly, please delete all existing indexes and create then all over again. Let me know if you run into any issue or if you find room for improvement from a user experience.