Set a default display name only when none is specified #15013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw you closed the PR #15012, you can fix the code on the same PR next time |
|
@hishamco yep i messed up something. |
MikeAlhayek
changed the title
|
@giannik thank you for looking into this. I was actually getting ready to submit a PR then saw yours. So instead, I hijacked you PR to provide a complete solutions. In your original PR, creating a field from migration will cause an exception. So I update the code to ensure it works on both cases "UI or migration" |
MikeAlhayek
added a commit
that referenced
this pull request
Jan 8, 2024
Co-authored-by: Mike Alhayek <[email protected]>
Merged
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
) Co-authored-by: Mike Alhayek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14985