Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update editorconfig file #15038

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Update editorconfig file #15038

merged 5 commits into from
Jan 11, 2024

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Jan 10, 2024

Adding suggestion to use file_scoped namespaces.

also disabling @sebastienros 2 favorite feature in C#12.

@hishamco
Copy link
Member

also disabling @sebastienros 2 favorite feature in C#12.

Why?

@Skrypt
Copy link
Contributor

Skrypt commented Jan 11, 2024

@hishamco I think it was sarcasm.

@MikeAlhayek
Copy link
Member Author

@hishamco

Use collection expression for fluent (IDE0305) will make the code hard to read since it is not natural. Also, the fact that it is a new syntax and not many people are using it or familiar with it will make them guess what it does and could cause issues.

Primary constructors are okay when you know don't need to add any kinds of checks in the constructor, but then what happen if we need to add a check? Do we keep altering between the two styles?

@Skrypt
Copy link
Contributor

Skrypt commented Jan 11, 2024

Primary constructor is just a different simplified syntax but personnally what I find annoying is the suggestion to change all classes to Primary constructors when working with VS Code.

I don't really bother about the new ToArray() syntax much but for consistency in OC it makes sense.

@MikeAlhayek MikeAlhayek enabled auto-merge (squash) January 11, 2024 22:07
@MikeAlhayek MikeAlhayek merged commit 512736d into main Jan 11, 2024
3 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/update-editorconfig branch January 11, 2024 22:27
hishamco pushed a commit that referenced this pull request Feb 1, 2024
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants