-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update editorconfig file #15038
Update editorconfig file #15038
Conversation
Why? |
@hishamco I think it was sarcasm. |
Use collection expression for fluent (IDE0305) will make the code hard to read since it is not natural. Also, the fact that it is a new syntax and not many people are using it or familiar with it will make them guess what it does and could cause issues. Primary constructors are okay when you know don't need to add any kinds of checks in the constructor, but then what happen if we need to add a check? Do we keep altering between the two styles? |
Primary constructor is just a different simplified syntax but personnally what I find annoying is the suggestion to change all classes to Primary constructors when working with VS Code. I don't really bother about the new ToArray() syntax much but for consistency in OC it makes sense. |
Adding suggestion to use file_scoped namespaces.
also disabling @sebastienros 2 favorite feature in C#12.
.ToArray()
syntax with a crazy syntax[..item]