Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when role names have different casing #15113

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

gvkries
Copy link
Contributor

@gvkries gvkries commented Jan 17, 2024

  • Always compare role names with ignored casing.
  • Fixes the casing of Anonymous and Authenticated roles in headless recipe.

I understand you guys don't want to do case-insensitive comparing in the role store, but I'd still argue this is the easiest fix if someone has an existing role which differs in casing only. If you want to do it differently, feel free to close this PR.

Fixes #15057

Fixes the casing of Anonymous and Authenticated roles in headless recipe.
@sebastienros sebastienros merged commit f3faf4d into OrchardCMS:main Feb 8, 2024
3 checks passed
@gvkries gvkries deleted the gvkries/rolestore-15057 branch February 15, 2024 08:36
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
Fixes the casing of Anonymous and Authenticated roles in headless recipe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Role name casing
3 participants