Upgrade graphql to 7.7.2 #15129

hyzx86 · 2024-01-19T17:19:04Z

Make a note of any problems you encounter during the upgrade

Upgrade the dependency package to GraphQL 7.7.2
All FieldType builds in the project were reconstructed in the way Graphql-dotnet 7.x recommended
fix Operation is not valid due to the current state of the object.

hyzx86 · 2024-01-19T17:20:12Z

@hishamco I just merged your code from the main branch and fixed the compilation errors, but the unit tests haven't been fixed yet

hyzx86 · 2024-01-19T17:25:07Z

Here's a question. I plan to add logging functionality to my generation unit test project.
Because unit tests see too few error messages
Do I add it directly in this PR or launch another PR?

#14347

hishamco · 2024-01-19T17:38:45Z

I prefer to do it in a separate PR

hyzx86 · 2024-01-19T17:49:38Z

I prefer to do it in a separate PR

OK, here #15130 , I'm going to merge the PR into this branch

hyzx86 · 2024-01-19T18:34:43Z

There seems to be only one problem for now

An unhandled exception has occurred while executing the request. System.InvalidOperationException: This graph type 'ContentPickerFieldQueryObjectType' with name 'ContentPickerField' has already been initialized. Make sure that you do not use the same instance of a graph type in multiple schemas. It may be so if you registered this graph type as singleton; see https://graphql-dotnet.github.io/docs/getting-started/dependency-injection/ for more info.
   at GraphQL.Types.GraphType.Initialize(ISchema schema) in /_/src/GraphQL/Types/GraphType.cs:line 33
   at GraphQL.Types.SchemaTypes.AddType(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 442
   at GraphQL.Types.SchemaTypes.AddTypeWithLoopCheck(IGraphType resolvedType, TypeCollectionContext context, Type namedType) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 632
   at GraphQL.Types.SchemaTypes.AddTypeIfNotRegistered(Type type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 664
   at GraphQL.Types.SchemaTypes.HandleField(IComplexGraphType parentType, FieldType field, TypeCollectionContext context, Boolean applyNameConverter) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 552
   at GraphQL.Types.SchemaTypes.AddType(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 449
   at GraphQL.Types.SchemaTypes.AddTypeIfNotRegistered(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 678
   at GraphQL.Types.SchemaTypes.HandleField(IComplexGraphType parentType, FieldType field, TypeCollectionContext context, Boolean applyNameConverter) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 557
   at GraphQL.Types.SchemaTypes.AddType(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 449
   at GraphQL.Types.SchemaTypes.AddTypeIfNotRegistered(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 678
   at GraphQL.Types.SchemaTypes.Initialize(ISchema schema, IServiceProvider serviceProvider, IEnumerable`1 graphTypeMappings) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 207
   at GraphQL.Types.SchemaTypes..ctor(ISchema schema, IServiceProvider serviceProvider, IEnumerable`1 graphTypeMappings) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 133
   at GraphQL.Types.SchemaTypes..ctor(ISchema schema, IServiceProvider serviceProvider) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 118
   at GraphQL.Types.Schema.CreateSchemaTypes() in /_/src/GraphQL/Types/Schema.cs:line 471
   at GraphQL.Types.Schema.CreateAndInitializeSchemaTypes() in /_/src/GraphQL/Types/Schema.cs:line 442
   at GraphQL.Types.Schema.Initialize() in /_/src/GraphQL/Types/Schema.cs:line 210
   at OrchardCore.Apis.GraphQL.Services.SchemaService.GetSchemaAsync() in D:\SourceCodes\JZSoft\OrchardCore\src\OrchardCore.Modules\OrchardCore.Apis.GraphQL\Services\SchemaService.cs:line 117
   at OrchardCore.Apis.GraphQL.GraphQLMiddleware.ExecuteAsync(HttpContext context, ISchemaFactory schemaService, IGraphQLSerializer graphQLSerializer) in D:\SourceCodes\JZSoft\OrchardCore\src\OrchardCore.Modules\OrchardCore.Apis.GraphQL\GraphQLMiddleware.cs:line 143
   at OrchardCore.Apis.GraphQL.GraphQLMiddleware.Invoke(HttpContext context, IAuthorizationService authorizationService, IAuthenticationService authenticationService, ISchemaFactory schemaService, IGraphQLSerializer graphQLSerializer) in D:\SourceCodes\JZSoft\OrchardCore\src\OrchardCore.Modules\OrchardCore.Apis.GraphQL\GraphQLMiddleware.cs:line 66
   at OrchardCore.Liquid.ScriptsMiddleware.Invoke(HttpContext httpContext) in D:\SourceCodes\JZSoft\OrchardCore\src\OrchardCore.Modules\OrchardCore.Liquid\ScriptsMiddleware.cs:line 70
   at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at OrchardCore.Diagnostics.DiagnosticsStartupFilter.<>c__DisplayClass3_0.<<Configure>b__1>d.MoveNext() in D:\SourceCodes\JZSoft\OrchardCore\src\OrchardCore.Modules\OrchardCore.Diagnostics\DiagnosticsStartupFilter.cs:line 34
--- End of stack trace from previous location ---
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddlewareImpl.<Invoke>g__Awaited|10_0(ExceptionHandlerMiddlewareImpl middleware, HttpContext context, Task task)    at GraphQL.Types.GraphType.Initialize(ISchema schema) in /_/src/GraphQL/Types/GraphType.cs:line 33
   at GraphQL.Types.SchemaTypes.AddType(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 442
   at GraphQL.Types.SchemaTypes.AddTypeWithLoopCheck(IGraphType resolvedType, TypeCollectionContext context, Type namedType) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 632
   at GraphQL.Types.SchemaTypes.AddTypeIfNotRegistered(Type type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 664
   at GraphQL.Types.SchemaTypes.HandleField(IComplexGraphType parentType, FieldType field, TypeCollectionContext context, Boolean applyNameConverter) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 552
   at GraphQL.Types.SchemaTypes.AddType(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 449
   at GraphQL.Types.SchemaTypes.AddTypeIfNotRegistered(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 678
   at GraphQL.Types.SchemaTypes.HandleField(IComplexGraphType parentType, FieldType field, TypeCollectionContext context, Boolean applyNameConverter) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 557
   at GraphQL.Types.SchemaTypes.AddType(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 449
   at GraphQL.Types.SchemaTypes.AddTypeIfNotRegistered(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 678
   at GraphQL.Types.SchemaTypes.Initialize(ISchema schema, IServiceProvider serviceProvider, IEnumerable`1 graphTypeMappings) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 207
   at GraphQL.Types.SchemaTypes..ctor(ISchema schema, IServiceProvider serviceProvider, IEnumerable`1 graphTypeMappings) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 133
   at GraphQL.Types.SchemaTypes..ctor(ISchema schema, IServiceProvider serviceProvider) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 118
   at GraphQL.Types.Schema.CreateSchemaTypes() in /_/src/GraphQL/Types/Schema.cs:line 471
   at GraphQL.Types.Schema.CreateAndInitializeSchemaTypes() in /_/src/GraphQL/Types/Schema.cs:line 442
   at GraphQL.Types.Schema.Initialize() in /_/src/GraphQL/Types/Schema.cs:line 210
   at OrchardCore.Apis.GraphQL.Services.SchemaService.GetSchemaAsync() in D:\SourceCodes\JZSoft\OrchardCore\src\OrchardCore.Modules\OrchardCore.Apis.GraphQL\Services\SchemaService.cs:line 117
   at OrchardCore.Apis.GraphQL.GraphQLMiddleware.ExecuteAsync(HttpContext context, ISchemaFactory schemaService, IGraphQLSerializer graphQLSerializer) in D:\SourceCodes\JZSoft\OrchardCore\src\OrchardCore.Modules\OrchardCore.Apis.GraphQL\GraphQLMiddleware.cs:line 143
   at OrchardCore.Apis.GraphQL.GraphQLMiddleware.Invoke(HttpContext context, IAuthorizationService authorizationService, IAuthenticationService authenticationService, ISchemaFactory schemaService, IGraphQLSerializer graphQLSerializer) in D:\SourceCodes\JZSoft\OrchardCore\src\OrchardCore.Modules\OrchardCore.Apis.GraphQL\GraphQLMiddleware.cs:line 66
   at OrchardCore.Liquid.ScriptsMiddleware.Invoke(HttpContext httpContext) in D:\SourceCodes\JZSoft\OrchardCore\src\OrchardCore.Modules\OrchardCore.Liquid\ScriptsMiddleware.cs:line 70
   at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at OrchardCore.Diagnostics.DiagnosticsStartupFilter.<>c__DisplayClass3_0.<<Configure>b__1>d.MoveNext() in D:\SourceCodes\JZSoft\OrchardCore\src\OrchardCore.Modules\OrchardCore.Diagnostics\DiagnosticsStartupFilter.cs:line 34
--- End of stack trace from previous location ---
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddlewareImpl.<Invoke>g__Awaited|10_0(ExceptionHandlerMiddlewareImpl middleware, HttpContext context, Task task)

… into upgrade-graphQL

hyzx86 · 2024-01-21T08:15:50Z

@hishamco There are too many expired warnings, after fixing all the warnings, upgrade 7.7.2 will not report errors, but the problem is still in the type registration

hishamco · 2024-01-21T09:58:19Z

Because there're deprecated members

hyzx86 · 2024-01-22T09:21:41Z

Because there're deprecated members

I've actually fixed all deprecated members

The problem now is
Unable to register GraphType 'InputObjectGraphType<AliasPart>' with the name 'InputObjectGraphType_1'. The name 'InputObjectGraphType_1' is already registered to 'InputObjectGraphType<TitlePart>'. Check your schema configuration.

An unhandled exception has occurred while executing the request. System.InvalidOperationException: Unable to register GraphType 'InputObjectGraphType<AliasPart>' with the name 'InputObjectGraphType_1'. The name 'InputObjectGraphType_1' is already registered to 'InputObjectGraphType<TitlePart>'. Check your schema configuration.
   at GraphQL.Types.SchemaTypes.SetGraphType(String typeName, IGraphType graphType) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 1031
   at GraphQL.Types.SchemaTypes.AddType(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 525
   at GraphQL.Types.SchemaTypes.AddTypeWithLoopCheck(IGraphType resolvedType, TypeCollectionContext context, Type namedType) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 727
   at GraphQL.Types.SchemaTypes.AddTypeIfNotRegistered(Type type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 760
   at GraphQL.Types.SchemaTypes.HandleField(IComplexGraphType parentType, FieldType field, TypeCollectionContext context, Boolean applyNameConverter) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 641
   at GraphQL.Types.SchemaTypes.AddType(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 533
   at GraphQL.Types.SchemaTypes.AddTypeIfNotRegistered(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 776
   at GraphQL.Types.SchemaTypes.HandleField(IComplexGraphType parentType, FieldType field, TypeCollectionContext context, Boolean applyNameConverter) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 677
   at GraphQL.Types.SchemaTypes.AddType(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 533
   at GraphQL.Types.SchemaTypes.AddTypeIfNotRegistered(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 776
   at GraphQL.Types.SchemaTypes.Initialize(ISchema schema, IServiceProvider serviceProvider, IEnumerable`1 graphTypeMappings) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 277
   at GraphQL.Types.SchemaTypes..ctor(ISchema schema, IServiceProvider serviceProvider, IEnumerable`1 graphTypeMappings) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 190
   at GraphQL.Types.SchemaTypes..ctor(ISchema schema, IServiceProvider serviceProvider) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 175
   at GraphQL.Types.Schema.CreateSchemaTypes() in /_/src/GraphQL/Types/Schema.cs:line 477
   at GraphQL.Types.Schema.CreateAndInitializeSchemaTypes() in /_/src/GraphQL/Types/Schema.cs:line 448
   at GraphQL.Types.Schema.Initialize() in /_/src/GraphQL/Types/Schema.cs:line 196
   at OrchardCore.Apis.GraphQL.Services.SchemaService.GetSchemaAsync() in D:\Code\gitcodes\OrchardCore\src\OrchardCore.Modules\OrchardCore.Apis.GraphQL\Services\SchemaService.cs:line 123
   at OrchardCore.Apis.GraphQL.GraphQLMiddleware.ExecuteAsync(HttpContext context) in D:\Code\gitcodes\OrchardCore\src\OrchardCore.Modules\OrchardCore.Apis.GraphQL\GraphQLMiddleware.cs:line 141
   at OrchardCore.Apis.GraphQL.GraphQLMiddleware.InvokeAsync(HttpContext context, RequestDelegate next) in D:\Code\gitcodes\OrchardCore\src\OrchardCore.Modules\OrchardCore.Apis.GraphQL\GraphQLMiddleware.cs:line 63
   at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.InterfaceMiddlewareBinder.<>c__DisplayClass2_0.<<CreateMiddleware>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at OrchardCore.Liquid.ScriptsMiddleware.Invoke(HttpContext httpContext) in D:\Code\gitcodes\OrchardCore\src\OrchardCore.Modules\OrchardCore.Liquid\ScriptsMiddleware.cs:line 70
   at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at OrchardCore.Diagnostics.DiagnosticsStartupFilter.<>c__DisplayClass3_0.<<Configure>b__1>d.MoveNext() in D:\Code\gitcodes\OrchardCore\src\OrchardCore.Modules\OrchardCore.Diagnostics\DiagnosticsStartupFilter.cs:line 34
--- End of stack trace from previous location ---
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddlewareImpl.<Invoke>g__Awaited|10_0(ExceptionHandlerMiddlewareImpl middleware, HttpContext context, Task task)    at GraphQL.Types.SchemaTypes.SetGraphType(String typeName, IGraphType graphType) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 1031
   at GraphQL.Types.SchemaTypes.AddType(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 525
   at GraphQL.Types.SchemaTypes.AddTypeWithLoopCheck(IGraphType resolvedType, TypeCollectionContext context, Type namedType) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 727
   at GraphQL.Types.SchemaTypes.AddTypeIfNotRegistered(Type type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 760
   at GraphQL.Types.SchemaTypes.HandleField(IComplexGraphType parentType, FieldType field, TypeCollectionContext context, Boolean applyNameConverter) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 641
   at GraphQL.Types.SchemaTypes.AddType(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 533
   at GraphQL.Types.SchemaTypes.AddTypeIfNotRegistered(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 776
   at GraphQL.Types.SchemaTypes.HandleField(IComplexGraphType parentType, FieldType field, TypeCollectionContext context, Boolean applyNameConverter) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 677
   at GraphQL.Types.SchemaTypes.AddType(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 533
   at GraphQL.Types.SchemaTypes.AddTypeIfNotRegistered(IGraphType type, TypeCollectionContext context) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 776
   at GraphQL.Types.SchemaTypes.Initialize(ISchema schema, IServiceProvider serviceProvider, IEnumerable`1 graphTypeMappings) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 277
   at GraphQL.Types.SchemaTypes..ctor(ISchema schema, IServiceProvider serviceProvider, IEnumerable`1 graphTypeMappings) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 190
   at GraphQL.Types.SchemaTypes..ctor(ISchema schema, IServiceProvider serviceProvider) in /_/src/GraphQL/Types/Collections/SchemaTypes.cs:line 175
   at GraphQL.Types.Schema.CreateSchemaTypes() in /_/src/GraphQL/Types/Schema.cs:line 477
   at GraphQL.Types.Schema.CreateAndInitializeSchemaTypes() in /_/src/GraphQL/Types/Schema.cs:line 448
   at GraphQL.Types.Schema.Initialize() in /_/src/GraphQL/Types/Schema.cs:line 196
   at OrchardCore.Apis.GraphQL.Services.SchemaService.GetSchemaAsync() in D:\Code\gitcodes\OrchardCore\src\OrchardCore.Modules\OrchardCore.Apis.GraphQL\Services\SchemaService.cs:line 123
   at OrchardCore.Apis.GraphQL.GraphQLMiddleware.ExecuteAsync(HttpContext context) in D:\Code\gitcodes\OrchardCore\src\OrchardCore.Modules\OrchardCore.Apis.GraphQL\GraphQLMiddleware.cs:line 141
   at OrchardCore.Apis.GraphQL.GraphQLMiddleware.InvokeAsync(HttpContext context, RequestDelegate next) in D:\Code\gitcodes\OrchardCore\src\OrchardCore.Modules\OrchardCore.Apis.GraphQL\GraphQLMiddleware.cs:line 63
   at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.InterfaceMiddlewareBinder.<>c__DisplayClass2_0.<<CreateMiddleware>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at OrchardCore.Liquid.ScriptsMiddleware.Invoke(HttpContext httpContext) in D:\Code\gitcodes\OrchardCore\src\OrchardCore.Modules\OrchardCore.Liquid\ScriptsMiddleware.cs:line 70
   at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at OrchardCore.Diagnostics.DiagnosticsStartupFilter.<>c__DisplayClass3_0.<<Configure>b__1>d.MoveNext() in D:\Code\gitcodes\OrchardCore\src\OrchardCore.Modules\OrchardCore.Diagnostics\DiagnosticsStartupFilter.cs:line 34
--- End of stack trace from previous location ---
   at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddlewareImpl.<Invoke>g__Awaited|10_0(ExceptionHandlerMiddlewareImpl middleware, HttpContext context, Task task)

… into upgrade-graphQL

hishamco · 2024-02-01T15:24:55Z

@sebastienros can we triage this today?

...OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Fields/ObjectGraphTypeFieldProvider.cs

src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/ContentItemsFieldType.cs

sebastienros · 2024-02-01T19:12:49Z

src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Types/TypedContentTypeBuilder.cs

-                var activator = typeActivator.GetTypeActivator(part.PartDefinition.Name);
-
-                var queryGraphType = typeof(ObjectGraphType<>).MakeGenericType(activator.Type);
+                var partType = PartTypes.GetOrAdd(part.PartDefinition.Name, key => typeActivator.GetTypeActivator(key).Type);


Now you are caching this one. So if the other one is not cache I assume it's because it doesn't have to?

src/OrchardCore/OrchardCore.ContentManagement.GraphQL/Queries/Types/TypedContentTypeBuilder.cs

test/OrchardCore.Tests/Apis/GraphQL/ContentItemsFieldTypeTests.cs

test/OrchardCore.Tests/Apis/Context/MvcTestFixture.cs

hishamco · 2024-02-01T19:24:13Z

I will keep updating this PR with @hyzx86

sebastienros · 2024-02-02T18:19:10Z

#15215 has been merged and needs to be updated.

sebastienros · 2024-02-02T18:21:20Z

This can be merged when the recent "current user" support has been handled

github-actions · 2024-02-02T19:15:08Z

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions · 2024-02-02T21:27:46Z

This pull request has merge conflicts. Please resolve those before requesting a review.

MikeAlhayek · 2024-02-06T00:53:21Z

@hyzx86 can you please fix the conflicts?

sebastienros · 2024-02-06T01:04:42Z

I fixed the conflicts, hope this is correct.

hishamco · 2024-02-06T11:09:40Z

Seems there's fail in the build, @hyzx86 could you please re-check

sebastienros · 2024-02-07T18:17:35Z

I fixed the build

Co-authored-by: Hisham Bin Ateya <[email protected]> Co-authored-by: hyzx86 <[email protected]> Co-authored-by: Sébastien Ros <[email protected]> Co-authored-by: Mike Alhayek <[email protected]>

hishamco and others added 3 commits February 14, 2023 09:09

Upgrade to GraphQL 7.2.2

064cd9a

Add media filenames on MediaFieldType

c3c2d82

merge latest code

4cdec82

hyzx86 changed the title ~~Upgrade graphql~~ Upgrade graphql to 7.2.2 Jan 19, 2024

add logs to unit tests

6998b7b

hyzx86 added 4 commits January 20, 2024 01:51

merge test log function

eb287b3

UseNLogHost()

acfa5ce

restore changes

32d8af3

update test log

7d8674b

hyzx86 and others added 5 commits January 20, 2024 22:59

fix LockedAsyncFieldResolver

681dc52

try upgrade graphql 7.7.2

9d71c8b

Merge branch 'main' into upgrade-graphQL

6bc4238

try remove all schema.RegisterType()

5007446

Merge branch 'upgrade-graphQL' of https://github.com/hyzx86/OrchardCore…

53d0e91

… into upgrade-graphQL

update dynamic field

2349912

hyzx86 changed the title ~~Upgrade graphql to 7.2.2~~ Upgrade graphql to 7.x Jan 21, 2024

hyzx86 and others added 2 commits January 22, 2024 00:10

update MenuItemInterface

43e28bf

Merge remote-tracking branch 'origin/main' into upgrade-graphQL

937c818

hyzx86 and others added 4 commits January 22, 2024 17:30

fix LuceneQueryFieldTypeProvider

a8b36e2

Merge branch 'main' into upgrade-graphQL

b5d0338

add types cache

c8e4062

Merge branch 'upgrade-graphQL' of https://github.com/hyzx86/OrchardCore…

f114d76

… into upgrade-graphQL

sebastienros reviewed Feb 1, 2024

View reviewed changes

hyzx86 added 4 commits February 2, 2024 14:12

add function ResolveContentItems in unit test

6a601a5

remove log in test

6c18b6b

remove log in test

ba5f95c

cache graphType

8ae797d

sebastienros removed the needs triage label Feb 2, 2024

sebastienros approved these changes Feb 2, 2024

View reviewed changes

github-actions bot added the merge conflict label Feb 2, 2024

Merge branch 'main' into upgrade-graphQL

a1d9686

github-actions bot added merge conflict and removed merge conflict labels Feb 2, 2024

Merge branch 'main' into upgrade-graphQL

815bb84

github-actions bot removed the merge conflict label Feb 6, 2024

sebastienros added 2 commits February 7, 2024 10:00

Fix build

da7ab9e

Merge branch 'main' into upgrade-graphQL

2a3b81f

Merge branch 'main' into upgrade-graphQL

193bda0

sebastienros merged commit 66d792c into OrchardCMS:main Feb 8, 2024
4 checks passed

MikeAlhayek mentioned this pull request Feb 12, 2024

InvalidOperationException when visiting GraphQL explorer #15304

Closed

hyzx86 deleted the upgrade-graphQL branch June 13, 2024 06:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade graphql to 7.7.2 #15129

Upgrade graphql to 7.7.2 #15129

hyzx86 commented Jan 19, 2024 •

edited

Loading

hyzx86 commented Jan 19, 2024

hyzx86 commented Jan 19, 2024 •

edited

Loading

hishamco commented Jan 19, 2024

hyzx86 commented Jan 19, 2024 •

edited

Loading

hyzx86 commented Jan 19, 2024

hyzx86 commented Jan 21, 2024

hishamco commented Jan 21, 2024

hyzx86 commented Jan 22, 2024 •

edited

Loading

hishamco commented Feb 1, 2024

sebastienros Feb 1, 2024

hishamco commented Feb 1, 2024

sebastienros commented Feb 2, 2024 •

edited

Loading

sebastienros commented Feb 2, 2024

github-actions bot commented Feb 2, 2024

github-actions bot commented Feb 2, 2024

MikeAlhayek commented Feb 6, 2024

sebastienros commented Feb 6, 2024

hishamco commented Feb 6, 2024

sebastienros commented Feb 7, 2024

Upgrade graphql to 7.7.2 #15129

Upgrade graphql to 7.7.2 #15129

Conversation

hyzx86 commented Jan 19, 2024 • edited Loading

hyzx86 commented Jan 19, 2024

hyzx86 commented Jan 19, 2024 • edited Loading

hishamco commented Jan 19, 2024

hyzx86 commented Jan 19, 2024 • edited Loading

hyzx86 commented Jan 19, 2024

hyzx86 commented Jan 21, 2024

hishamco commented Jan 21, 2024

hyzx86 commented Jan 22, 2024 • edited Loading

hishamco commented Feb 1, 2024

sebastienros Feb 1, 2024

Choose a reason for hiding this comment

hishamco commented Feb 1, 2024

sebastienros commented Feb 2, 2024 • edited Loading

sebastienros commented Feb 2, 2024

github-actions bot commented Feb 2, 2024

github-actions bot commented Feb 2, 2024

MikeAlhayek commented Feb 6, 2024

sebastienros commented Feb 6, 2024

hishamco commented Feb 6, 2024

sebastienros commented Feb 7, 2024

hyzx86 commented Jan 19, 2024 •

edited

Loading

hyzx86 commented Jan 19, 2024 •

edited

Loading

hyzx86 commented Jan 19, 2024 •

edited

Loading

hyzx86 commented Jan 22, 2024 •

edited

Loading

sebastienros commented Feb 2, 2024 •

edited

Loading