Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqllite DatabaseName was not read from appsettings #15138

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Sqllite DatabaseName was not read from appsettings #15138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f6b5a0
Sqllite DatabaseName was not read from appsettings
microposmp Jan 20, 2024
854d8b6
Bind all values in config section.
microposmp Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OrchardCore/OrchardCore.Data.YesSql/Options/SqliteOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class SqliteOptions
/// <para>There may be a performance penalty associated with disabling connection pooling.</para>
/// <see href="https://docs.microsoft.com/en-us/dotnet/standard/data/sqlite/connection-strings#pooling" />
/// </summary>
public bool UseConnectionPooling { get; set; }
public bool UseConnectionPooling { get; set; } = true;

/// <summary>
/// Gets or sets the database name. Defaults to <c>OrchardCore.db</c>.
Expand Down
3 changes: 1 addition & 2 deletions src/OrchardCore/OrchardCore.Data.YesSql/Options/SqliteOptionsConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ namespace OrchardCore.Data
{
public class SqliteOptionsConfiguration : IConfigureOptions<SqliteOptions>
{
private static readonly bool _defaultUseConnectionPooling = true;
private readonly IShellConfiguration _shellConfiguration;

public SqliteOptionsConfiguration(IShellConfiguration shellConfiguration)
Expand All @@ -18,7 +17,7 @@ public void Configure(SqliteOptions options)
{
var section = _shellConfiguration.GetSection("OrchardCore_Data_Sqlite");

options.UseConnectionPooling = section.GetValue(nameof(options.UseConnectionPooling), _defaultUseConnectionPooling);
section.Bind(options);
}
}
}