Update Serilog.AspNetCore 8.0.0 #15151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add docs / release notes for people that were using the extension method? |
|
and make it Obsolete during at least one version and warn that it will disappear, before removing it? |
|
Nothing to be removed, Serlog deprecated the method but while we have an extension method the user will no longer notice if there's a breaking-change in |
Piedone
requested changes
Feb 11, 2024
src/OrchardCore/OrchardCore.Logging.Serilog/WebHostBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
|
@Piedone let's merge this |
Piedone
approved these changes
Feb 26, 2024
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
* Update Serilog.AspNetCore 8.0.0 * Revert changes --------- Co-authored-by: Zoltán Lehóczky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/serilog/serilog-aspnetcore/releases/tag/v8.0.0
https://www.nuget.org/packages/Serilog.AspNetCore/8.0.0