Use ReadOnly Session when indixing content items #15216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
reviewed
Jan 31, 2024
| @@ -81,6 +81,7 @@ public async Task ProcessContentItemsAsync(params string[] indexNames) | |||
| var tasks = new List<IndexingTask>(); | |||
|
|
|||
| var allContentTypes = indexSettings.SelectMany(x => x.IndexedContentTypes ?? []).Distinct().ToList(); | |||
| var readOnlySession = _store.CreateSession(withTracking: false); | |||
There was a problem hiding this comment.
no. I purposely called it readOnlySession to indicate that it is a session for read only.
hishamco
pushed a commit
that referenced
this pull request
Feb 1, 2024
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YeSql has a new way of creating session for readonly scenarios. Reducing the caching objects when doing read-only operation should reduce unwanted caching/allocation done by yessql internally.
This should be useful when fetching data for read only scenario.