Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recipe steps with polymorphic types #15320

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Conversation

sebastienros
Copy link
Member

Fixes #15246

@MikeAlhayek
Copy link
Member

@sebastienros I think this works. But I think we also need to do the same things with deployment. If you try to export the Admin menu using deployment, the JSON looks like this

{
  "steps": [
    {
      "name": "AdminMenu",
      "data": [
        {
          "Id": "baef6f85ad13481681cde70ada401333",
          "Name": "Admin menus",
          "Enabled": true,
          "MenuItems": [
            {
              "UniqueId": "7b293d57056a4eebb3713f07f12c65d8",
              "Enabled": true,
              "Priority": 0,
              "LinkToFirstChild": true,
              "LocalNav": false,
              "Items": [],
              "Classes": []
            },
            {
              "UniqueId": "5118cecfde834dacb26ac08980f1b5a7",
              "Enabled": true,
              "Priority": 0,
              "LinkToFirstChild": true,
              "LocalNav": false,
              "Items": [],
              "Classes": []
            },
            {
              "UniqueId": "3e590d44f8704e4588e272dd966ce291",
              "Enabled": true,
              "Priority": 0,
              "LinkToFirstChild": true,
              "LocalNav": false,
              "Items": [
                {
                  "Position": "0",
                  "Priority": 0,
                  "LinkToFirstChild": true,
                  "LocalNav": false,
                  "Items": [],
                  "Classes": []
                },
                {
                  "Position": "1",
                  "Priority": 50,
                  "LinkToFirstChild": true,
                  "LocalNav": false,
                  "Items": [
                    {
                      "Priority": 0,
                      "LinkToFirstChild": true,
                      "LocalNav": false,
                      "Items": [],
                      "Classes": []
                    }
                  ],
                  "Classes": []
                }
              ],
              "Classes": []
            }
          ]
        }
      ]
    }
  ]
}

@sebastienros
Copy link
Member Author

@MikeAlhayek fixed

@MikeAlhayek
Copy link
Member

I'll give it a try.

Since you are in STJ mind set, have a look at this issue if you have time #15322

@MikeAlhayek
Copy link
Member

Still not working.

Copy link
Member

@MikeAlhayek MikeAlhayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually did another test. The Admin Menu seems to be working.

@MikeAlhayek MikeAlhayek merged commit f6e4251 into main Feb 13, 2024
5 checks passed
@MikeAlhayek MikeAlhayek deleted the sebros/polymorphicsteps branch February 13, 2024 16:10
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AdminMenuNavigationProvidersCoordinator issue in main branch
2 participants