Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file-scoped namespace (IDE0161) #15415

Closed
wants to merge 2 commits into from
Closed

Use file-scoped namespace (IDE0161) #15415

wants to merge 2 commits into from

Conversation

MikeAlhayek
Copy link
Member

This will break every PR we have.

To fix the PR, open command line and execute the following code

dotnet format --diagnostics IDE0161 --severity info

This should fix the PR.

Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@hishamco
Copy link
Member

I already did something similar in the past, and then @sebastienros or someone else told me that such this would break almost all the PRs

I prefer to do this incrementally to avoid break others PRs

@MikeAlhayek
Copy link
Member Author

yes I agree with you. it'll break every PR. That's why I added the command that every PR will have to apply to fix the conflicts all at once.

It's something we discussed during the meet today. Also, check out the 2 submitted PRs around formatting which will cause the same affect for all PRs.

@Skrypt
Copy link
Contributor

Skrypt commented Feb 28, 2024

We should probably have all of these figured out in a single PR instead. CI steps included if any.

Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@Piedone
Copy link
Member

Piedone commented Mar 13, 2024

Yeah, it would be nice to apply all such formatting changes at once, because then at least we break all PRs just once. And CI is definitely needed, so we don't re-introduce the same issues. See #7950.

@MikeAlhayek
Copy link
Member Author

Yes. I think @Skrypt is going to create an action to apply the same fix across PR. I also think he wants to merge this with his PR. I am closing this one for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants