-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use file-scoped namespace (IDE0161) #15415
Conversation
This pull request has merge conflicts. Please resolve those before requesting a review. |
I already did something similar in the past, and then @sebastienros or someone else told me that such this would break almost all the PRs I prefer to do this incrementally to avoid break others PRs |
yes I agree with you. it'll break every PR. That's why I added the command that every PR will have to apply to fix the conflicts all at once. It's something we discussed during the meet today. Also, check out the 2 submitted PRs around formatting which will cause the same affect for all PRs. |
We should probably have all of these figured out in a single PR instead. CI steps included if any. |
This pull request has merge conflicts. Please resolve those before requesting a review. |
Yeah, it would be nice to apply all such formatting changes at once, because then at least we break all PRs just once. And CI is definitely needed, so we don't re-introduce the same issues. See #7950. |
Yes. I think @Skrypt is going to create an action to apply the same fix across PR. I also think he wants to merge this with his PR. I am closing this one for now. |
This will break every PR we have.
To fix the PR, open command line and execute the following code
This should fix the PR.