Consolidate admin required fields #15545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add star char for all required fields + add validation message for required input field like in TitlePart * consolidate color for start and validation error messages * consolidate error message texts - remove client validation from inputs because of inconsistent form behaviour dependent on used browser, selected locale, ... OrchardCMS#15434
|
@dotnet-policy-service agree |
sebastienros
approved these changes
Mar 21, 2024
|
@all-contributors please add @xtomas for code. |
|
I've put up a pull request to add @xtomas! 🎉 |
Skrypt
reviewed
Mar 22, 2024
| @@ -6,11 +6,12 @@ | |||
|
|
|||
| <script asp-name="jQuery-ui-i18n" at="Foot"></script> | |||
| <div class="@Orchard.GetFieldWrapperClasses(Model.PartFieldDefinition)" id="@Html.IdFor(x => x.Value)_FieldWrapper"> | |||
There was a problem hiding this comment.
Have you tried with asp-validation-class-for="Value" on this div to set the entire "field" to be set has having a validation error?
|
@Skrypt do you have anything else to add or shall we merge this? |
|
It's approved; you can merge but I'm just asking if we should not also add the asp-validation-class-for too then to make this consistent everywhere. |
|
What's the wrong with |
|
It is missing everywhere for these fields. But we use it in ActivityDisplayDrivers editors for example. |
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15434
New test content item form with required fields
And the same content item after Publish